From 7197f8cc6aa9eff1b0b54dfc2fe9caa0f5d56ea0 Mon Sep 17 00:00:00 2001 From: Katerina Koukiou Date: Wed, 9 Oct 2024 18:12:09 +0200 Subject: [PATCH] Fix disabled VM action dropdown item tooltip When using `isDisabled` property in Buttons/Dropdowns/etc, their tooltips are not getting triggered. We need to use `isAriaDisabled` instead of `isDisabled` in this case. See more info: https://github.com/patternfly/patternfly-react/issues/5826 --- src/components/vm/vmActions.jsx | 2 +- test/check-machines-lifecycle | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/vm/vmActions.jsx b/src/components/vm/vmActions.jsx index 4ae6e153a..81305c886 100644 --- a/src/components/vm/vmActions.jsx +++ b/src/components/vm/vmActions.jsx @@ -473,7 +473,7 @@ const VmActions = ({ vm, vms, onAddErrorNotification, isDetailsPage }) => { + isAriaDisabled> {_("Delete")} diff --git a/test/check-machines-lifecycle b/test/check-machines-lifecycle index 015b822a0..5a8daa1af 100755 --- a/test/check-machines-lifecycle +++ b/test/check-machines-lifecycle @@ -530,7 +530,7 @@ class TestMachinesLifecycle(machineslib.VirtualMachinesCase): m.execute(f"virsh undefine {name}") b.wait_visible(f"tr[data-row-id=vm-{name}-system][data-vm-transient=true]") b.click(f"#vm-{name}-system-action-kebab") - b.wait_visible(f".pf-m-disabled #vm-{name}-system-delete") # delete buton should be disabled + b.wait_visible(f".pf-m-aria-disabled #vm-{name}-system-delete") # delete buton should be disabled b.click(f"#vm-{name}-system-forceOff") b.wait_visible(f"#vm-{name}-system-confirm-action-modal") b.click(f".pf-v5-c-modal-box__footer #vm-{name}-system-forceOff")