Keep the path as string instead of an array #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testBookmark fails everwhere. |
jelly
force-pushed
the
path-as-str
branch
3 times, most recently
from
357dbb1 to
1bf739b
Compare
jelly
commented
Jul 31, 2024
src/files-breadcrumbs.tsx
Outdated
| path = path.slice(path.length - 1); | ||
| const PathBreadcrumbs = ({ path }: { path: string }) => { | ||
| const path_array = path.split("/"); | ||
| if (path.endsWith("/") && path_array.length > 1) { |
There was a problem hiding this comment.
Needs a comment, why this is needed :-)
There was a problem hiding this comment.
Or alternative implementation..
jelly
commented
Jul 31, 2024
Comment on lines
+82
to
+83
| if (!currentPath.startsWith("/")) { | ||
| currentPath = `/${currentPath}`; |
jelly
commented
Jul 31, 2024
| defaultBookmarks.push({ name: _("Home"), loc: user?.home }); // TODO: add trash | ||
| if (user?.home) { | ||
| // Ensure the home dir has a trailing / like the path | ||
| const home_dir = user.home.endsWith('/') ? user.home : `${user.home}/`; |
There was a problem hiding this comment.
Yup, never seen user.home be /home/admin/ it always is /home/admin so that's logical.
jelly
force-pushed
the
path-as-str
branch
2 times, most recently
from
73043d9 to
e7a7c0d
Compare
There is no good reason to keep the path as an array of strings, usually we want to just append a file to the path for file operations as most of the code simply joined the path back to a string. This also makes sure the path is properly formatted as /path/to/thing/ with a leading and trailing /.
cockpituous
reviewed
Jul 31, 2024
Comment on lines
+82
to
+83
| if (!currentPath.startsWith("/")) { | ||
| currentPath = `/${currentPath}`; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| defaultBookmarks.push({ name: _("Home"), loc: user?.home }); // TODO: add trash | ||
| if (user?.home) { | ||
| // Ensure the home dir has a trailing / like the path | ||
| const home_dir = user.home.endsWith('/') ? user.home : `${user.home}/`; |
There was a problem hiding this comment.
This added line is not executed by any test.
| } | ||
| ); | ||
| } else if (selected.length > 1) { | ||
| menuItems.push( | ||
| { | ||
| id: "copy-item", | ||
| title: _("Copy"), | ||
| onClick: () => setClipboard(selected.map(s => path.join("/") + "/" + s.name)), | ||
| onClick: () => setClipboard(selected.map(s => path + s.name)), |
There was a problem hiding this comment.
This added line is not executed by any test.
tomasmatus
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no good reason to keep the path as an array of strings, usually we want to just append a file to the path for file operations as most of the code simply joined the path back to a string.
This also makes sure the path is properly formatted as /path/to/thing/ with a leading and trailing /.
///and///foo///