Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details view: Permissions #565

Closed
garrett opened this issue Jun 18, 2024 · 5 comments · Fixed by #623
Closed

Details view: Permissions #565

garrett opened this issue Jun 18, 2024 · 5 comments · Fixed by #623
Assignees
Labels
enhancement New feature or request

Comments

@garrett
Copy link
Member

garrett commented Jun 18, 2024

For showing permissions, I think the only thing that makes sense is to have the descriptive form with triplet attributes (not octal), and have descriptions for it in a tooltip to make it more approachable, like this:

permissions in details, with a tooltip

Note the spacing, lack of d (as we have another place to show if it's a directory or file`), and grouping. The tooltip has alignment on the labels and for the content, so the content aligns (and isn't ragged due to being all in one line).

Originally posted by @garrett in #564 (comment)

@garrett garrett added the enhancement New feature or request label Jun 18, 2024
@jelly
Copy link
Member

jelly commented Jun 18, 2024

As we can sort on this column, we need some text for the filter dropdown:

image

Or do we leave it out of this dropdown?

@allisonkarlitskaya
Copy link
Member

allisonkarlitskaya commented Jun 18, 2024

Sorting on permissions seems pretty marginal.

Copying from #564 (comment) :

Please make sure to support s (+xs), S (+s-x) and t/T (sticky) in the output for permissions.

@jelly
Copy link
Member

jelly commented Jun 18, 2024

Sorting on permissions seems pretty marginal.

Marginal? If you mean not important, sure, but as nautilus allows it, it seems like something we should do as well.

@garrett
Copy link
Member Author

garrett commented Jun 20, 2024

Nautilus allows it from the headers, but doesn't have it in the menu.

image

We're trying to balance 3 different factors when it comes to sorting the table:

  1. Permissions (and ownership) on a multi-user system are more important compared to a single-user desktop, so we shouldn't do a 1:1 duplication of desktop file manager features without thinking about it further.
  2. Cognitive overload (aka: "mental workload" / "info paralysis" / "paradox of choice"): having too many items in the sort list will make it harder to find what people are looking for.
  3. View compatibility: sorting options in the list need to make sense for both icon view and details view. Sorting by permissions isn't an obvious sorting order in icon view (it will look random).

Item 1 says it makes sense and can even be important on a server to sort by permission. Items 2 and 3 say adding it to the list will make that too cluttered, especially for the icon view. This is probably why Nautilus does not show permissions by default (due to 2 and 3, but also due to 1 as a single-user desktop system will generally own all the files themselves) and even when Nautilus is told to include permissions in the view, it does not add it to the menu (as that would be cluttered and not support both view modes).


On the other hand, KDE's Dolphin has these sorting options and much more. But it gets weird, as you can't see the sorting in the default view (icons) when you select it, and the menu structure is a mess. KDE often will add features just because it can, so I don't think it's a good standard to compare to.

image


Windows is weird (sometimes the menu is there, sometimes it isn't) and doesn't have permissions:

image

But Windows also has a plethora of mostly-redundant view options (with even more hidden in Windows 3.1-style dialogs in the ... menu under "Properties" and "Options"):

image

And Windows has 2 context menus, both with different options from the rest of the UI:

image

image

(The second one is triggered by selecting "More options" from the first.)


macOS Finder does sorting a little different. There's a menu in the headerbar that has various options, and when you select one other than the name (which just sorts by name), it groups the items with sticky headers:

image

image

image

image

But it gets a little wacky, as they have this duplicated in a ... menu that changes based on sort, what you have selected, and everything. Here's what it looks like with lots of options:

image

image

Same, but something's selected:

image

And then they have a "show view options" dialog that has many of the same settings, but even more to adjust the padding, spacing, font size, background wallpaper image (for the folder!), and so on, and that can be specific to the folder but also apply anywhere:

image


Anyway, looping back to the topic at hand:

  • We definitely should have permissions as a sortable header.
  • Even setting cognative overload aside, having the sort and icon view is odd, right?
  • Only KDE has permissions; it's not in the view of other file managers (except Nautilus, but there it's opt-in for details view only).
  • Everyone except KDE tries to keep the sorting (and grouping, when available, like on macOS and Windows) list shorter.
  • Even KDE tries to shorten the list with an overflow, but it's huge even prior to the overflow.

And, more in depth (overall), but still applies here:

  • We can't be more absurd than Windows, macOS, or KDE unless we spend literal decades shoving new features in multiple places and never reevaluating things or tried our hardest to be weird.
  • GNOME has iterated on the Nautilus UI and shuffled things around after thinking, so it's a pretty good reference, but isn't perfect.
  • All of these examples are mainly for desktop UIs. Windows does have a multi-user server version, however; but I don't know if the UI is different for it.

@garrett
Copy link
Member Author

garrett commented Jun 20, 2024

Here's the most recent mockup for a list view:

details mockups

It's not easy to have divider lines in Penpot, so I haven't added them yet. (It's possible, but requires workarounds.) Therefore, ignore the lack of it. We can decide if we want divider lines still or not. The lack of lines isn't intentional.

tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 3, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 22, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 24, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort by
permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 29, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort
by permissions. Sorting is done by comparing permission octal values.
tomasmatus added a commit to tomasmatus/cockpit-files that referenced this issue Jul 29, 2024
fixes: cockpit-project#565

Adds permissions column to details view with the ability to sort
by permissions. Sorting is done by comparing permission octal values.
@jelly jelly closed this as completed in 910c783 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants