Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with_time unimplemented #465

Closed
djwf opened this issue Mar 30, 2022 · 3 comments
Closed

with_time unimplemented #465

djwf opened this issue Mar 30, 2022 · 3 comments
Assignees
@djwf
Labels
bug Not as expected question Uncertainty is involved std-compatibility Jekyll flavor of liquid

Comments

@djwf
Copy link
Contributor

djwf commented Mar 30, 2022

As discussed in #252, the with_time method is unimplemented (always returns Nil).

Discussion about implementing that method, and other fixes required to do so, belong here.
@djwf djwf added bug Not as expected question Uncertainty is involved labels Mar 30, 2022
@djwf djwf self-assigned this Mar 30, 2022
@djwf djwf added the std-compatibility Jekyll flavor of liquid label Mar 30, 2022
@djwf
Copy link
Contributor Author

djwf commented Mar 30, 2022

It turns out that our DateTime implementation does not handle dates and times without offsets, so we'll need another issue for that.

@epage
Copy link
Member

epage commented Mar 30, 2022

See #48

@djwf djwf mentioned this issue Apr 1, 2022
Merged
1 task
@djwf
Copy link
Contributor Author

djwf commented Apr 1, 2022

Fixed by #466

@djwf djwf closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djwf djwf

Labels
bug Not as expected question Uncertainty is involved std-compatibility Jekyll flavor of liquid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @djwf