-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot iterate over "object" #201
Labels
enhancement
Improve the expected
Comments
Thanks for reporting this! I'll try to get to this tonight to unblock you. btw that liquid document is a lot better than the one I've been using. I'll need to audit liquid-rust against that. |
It's the one in the readme 😃 |
Thats what I get for using google rather than our own readme :) |
epage
added a commit
to epage/liquid-rust
that referenced
this issue
Oct 4, 2018
Not the fastest implementation but it will do for now. Fixes cobalt-org#201
1 task
epage
added a commit
to epage/liquid-rust
that referenced
this issue
Oct 4, 2018
Not the fastest implementation but it will do for now. Fixes cobalt-org#201
Cobalt PR: cobalt-org/cobalt.rs#526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
liquid-rust version: 0.14.3 and 0.15.0 (cobalt v0.12.2 and master)
rust version: rustc 1.29.1 (b801ae664 2018-09-20)
OS: Xubuntu 18.04
Attempting to iterate over an object from data is not possible. A small reproduction with cobalt is available here with the
cobalt build
output:I'm posting it here instead of the cobalt.rs repo since it seems this library is the root cause of the error. I tried with the latest release v0.12.2 (liquid-rust 0.14.3) and compiled from source from the master branch (liquid-rust 0.15.0).
I encountered this while porting the arewewebyet site from Jekyll to Cobalt, where the authors data file is iterated over once to get a list of curators, and then used elsewhere other times by other templates mostly as an object.
It definitely works in Jekyll, and the Liquid docs mention the types allowed in for loops. Here I'm assuming a hash is equivalent to what is called an object here, as it works as expected with Jekyll.
The text was updated successfully, but these errors were encountered: