Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests #90

Closed
hackeryarn opened this issue Apr 26, 2016 · 5 comments
Closed

Failing tests #90

hackeryarn opened this issue Apr 26, 2016 · 5 comments
Milestone
1.0

Comments

@hackeryarn
Copy link

I believe #88 caused tests to start failing because of how the documents are being condensed with the new type.

failures:
    copy_files
    custom_template_extensions
    dotfiles
    example
    rss
    sort_posts
@johannhof
Copy link
Contributor

They're not failing on Travis, what's the error you are getting?

@hackeryarn
Copy link
Author

So I ran the tests on a few platforms and appears to be windows specific issue. It seems the escape character encoding on windows causes the test to fail. I don't think this is something we can fix and would just need to add a note about.

The gist of the error is below, including all the tests which are failing.


---- copy_files stdout ----
        <!DOCTYPE html>
<html>
    <head>
        <title>My blog - My first Blogpost</title>
    </head>
    <body>
        <h1>My first �[91mBlogpost</h1>
<p>Hey�[0m �[92mBlogpost</h1>
<p>Hey�[0m there this is my first blogpost and this is super �[91mawesome.</p>
<p>My�[0m �[92mawesome.</p>
<p>My�[0m Blog is lorem ipsum like, yes it �[91mis..</p>

   �[0m �[92mis..</p>

   �[0m </body>
</html>


thread 'copy_files' panicked at 'assertion failed: edit distance between "<!DOCTYPE html>\r\n<html>\r\n    <head>\r\n        <title>My blog - My first Blogpost</title>\r\n    </head>\r\n    <body>\r\n        <h1>My first Blogpost</h1>\r\n<p>Hey there this is my first blogpost and this is super awesome.</p>\r\n<p>My Blog is lorem ipsum like, yes it is..</p>\r\n\r\n    </body>\r\n</html>\r\n\r\n" and "<!DOCTYPE html>\r\n<html>\r\n    <head>\r\n        <title>My blog - My first Blogpost</title>\r\n    </head>\r\n    <body>\r\n        <h1>My first Blogpost</h1>\n<p>Hey there this is my first blogpost and this is super awesome.</p>\n<p>My Blog is lorem ipsum like, yes it is..</p>\n\r\n    </body>\r\n</html>\r\n\r\n" is 6 and not 0, see diffset above', C:\Users\artem\.cargo\registry\src\github.com-88ac128001ac3a9a\difference-0.4.1\src\lib.rs:86


failures:
    copy_files
    custom_template_extensions
    dotfiles
    example
    rss
    sort_posts

@johannhof
Copy link
Contributor

Oh, interesting. I'll look into it, thanks for reporting. :)

@johannhof johannhof mentioned this issue May 14, 2016
Open
@johannhof johannhof added this to the 1.0 milestone Jul 12, 2016
@johannhof
Copy link
Contributor

Can be witnessed on Appveyor https://ci.appveyor.com/project/johannhof/cobalt-rs, I think that it's both about new lines and some backslashes not being converted to forward slashes correctly.

@johannhof
Copy link
Contributor

Since test on Appveyor are now succeeding I'll close this, although strangely we didn't fix the linebreak issue. Feel free to reopen if anyone can reproduce.

@sudoforge sudoforge mentioned this issue Apr 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@hackeryarn @johannhof