Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows换行符"\r\n" #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix windows换行符"\r\n" #591

wants to merge 1 commit into from

Conversation

zysam
Copy link
Contributor

@zysam zysam commented Nov 8, 2015

修复在windows下测试不通过。

修复在windows下测试不通过。
@zysam
Copy link
Contributor Author

zysam commented Nov 8, 2015

奇怪,能重新测试吗?

@alsotang
Copy link
Member

alsotang commented Nov 8, 2015

这。。。真的存在吗?
windows 在网页上也是 \r\n????

@alsotang
Copy link
Member

alsotang commented Nov 8, 2015

我已经让它重跑了,这个肯定是能过的。

@JacksonTian
Copy link
Member

👍

@zysam
Copy link
Contributor Author

zysam commented Nov 9, 2015

win下本地测试的。也考虑过如果不是本地,会不会有特殊情况,让我再找找。

@alsotang
Copy link
Member

alsotang commented Nov 9, 2015

你的 server 是 windows?

@alsotang
Copy link
Member

alsotang commented Nov 9, 2015

你看看这东西能不能满足:https://nodejs.org/api/os.html#os_os_eol

@zysam
Copy link
Contributor Author

zysam commented Nov 9, 2015

没代理还真上传不了图片。:(

是这样的。我在windows环境下跑测试。

/*
我爱北京天安门<script>alert(1)
</script>
*/

这种多行文本在windows的文件里,肯定是/r/n来换行的。但网页上的,我没确定。

@alsotang
Copy link
Member

alsotang commented Nov 9, 2015

在 win 的文件里,你 clone 项目的时候,里面是 \n。你的编辑器会自动把 \n 转成 \r\n??不会的吧

@zysam
Copy link
Contributor Author

zysam commented Nov 9, 2015

在 win 的文件里,你 clone 项目的时候,里面是 \n。你的编辑器会自动把 \n 转成 \r\n??不会的吧

会!
escapeSignature 貌似没被使用过 。。。只有用在测试用例上。。晕!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants