Fix u8 eq #1
Open
Fix u8 eq #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test fix install dir
|
I design the fix without having to do subtraction which seems to be causing the problem... Everything is done now by looping over the initial mat and filling out the 2 we are creating. |
|
@gonuke not sure what we want to do with this. Also found out we don't have unit test for this... |
bam241
commented
Sep 17, 2022
| @@ -1 +1,2 @@ | |||
| build | |||
| .DS_Store | |||
There was a problem hiding this comment.
this is because Mac OS is annoying
| @@ -1,4 +1,3 @@ | |||
| ===== | |||
There was a problem hiding this comment.
This I don't know... I can revert it if need be
| @@ -1,7 +1,7 @@ | |||
| ### DO NOT DELETE THIS COMMENT: INSERT_ARCHETYPES_HERE ### | |||
| USE_CYCLUS("cycvt" "special_enrich") | |||
|
|
|||
| INSTALL_CYCLUS_MODULE("cycvt" "./cycvt") | |||
| INSTALL_CYCLUS_MODULE("cycvt" "" "NONE") | |||
There was a problem hiding this comment.
This is copied from cycamore, otherwise cycvt was compiling but not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the observe bug :
free(): double free detected in tcache 2It occurred manipulated mats and compo when creating 2 materials from a mat, one containing the special nucs and one similar to the initial one expect that all special nucs were replaced by u238