Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamus Proposal #189

Closed
wants to merge 13 commits into from
Closed

Kamus Proposal #189

wants to merge 13 commits into from

Conversation

omerlh
Copy link

@omerlh omerlh commented Jan 15, 2019

Added a proposal to include Kamus as sandbox project.
Close #188
CC @caniszczyk - I can't tag cncf/toc...
Signoff by: Omer Levi Hevroni (Soluto)

Signed-off-by: omerlh <[email protected]>
@caniszczyk
Copy link
Contributor

RFC @cncf/toc

This project seems a bit too early stage IMHO, can you describe more where it's being used in production and how many contributors you have from different organizations?

@omerlh
Copy link
Author

omerlh commented Jan 15, 2019

I know, I also thought it might be too soon - but then I looked on the sandbox definition. It seems like a perfect fit for Kamus, as it designed for a project in a really early stage. For example:

Independent projects that fit the CNCF mission and provide potential for a novel approach to existing functional areas (or are an attempt to meet an unfulfilled need)

I think that Kamus fit this definition.

Regarding users/community contribution. The project is in a very early stage, but started to get some traction. There is some activity on issues, not direct contribution yet.
Regarding where it is in production - currently only at Soluto, I heard from a few people who wanted to give it a try. Hope to see them using it soon.

I might have mistaken regarding the purpose of the sandbox - and if so, I can close this PR and re-open it when we have enough traction (can you clarify what you think is considered enough? it's stated what is required for stage, not for sandbox).

@quinton-hoole
Copy link
Contributor

quinton-hoole commented Jan 16, 2019

Yes, to be clear, sandbox does not require production use, or significant numbers of contributors (yet).

It is intended as neutral home within which the above can be achieved.

That being said, you will still need at least two TOC sponsors, in whose opinion the project holds sufficient promise to be hosted in the CNCF.

@omerlh
Copy link
Author

omerlh commented Jan 28, 2019

That being said, you will still need at least two TOC sponsors, in whose opinion the project holds sufficient promise to be hosted in the CNCF.

I know, I wasn't sure how I can ask for sponsors - this is why I opened this PR. Hope this is the right move...

@omerlh
Copy link
Author

omerlh commented Feb 5, 2019

The build failed due to billing issue I think:

Please update billing information for cncf

Also, I saw the presentation for tomorrow meeting - should Kamus be added to the Project presentation track spreadsheet?

@mattklein123
Copy link
Contributor

@omerlh I'm potentially interested in sponsoring but I would appreciate it if you could add a "comparison to similar systems" section to your docs? I'm curious how you see Kamus compared to https://github.com/hashicorp/vault, https://github.com/lyft/confidant, etc. AFAICT the major difference is distributed vs. central secret storage?

Also, how do you foresee key rotation in this system? This seems like a flaw in a distributed storage system whereas in a central system secrets can potentially be re-encrypted if needed?

@omerlh
Copy link
Author

omerlh commented May 5, 2019

Hey Matt! I'm happy to hear so.
Thanks for the feedback - I added a section about comparing Kamus to other systems. Please let me know what you think about it. Like you already said - the main difference is distributed vs centralized storage of the secret. I see it as a culture difference - it's going down to who is responsible for the deployments in a company. Companies that favor decentralized (DevOps?) culture, might prefer a decentralized solution.

Regarding key rotation - this issue covers some of the tasks requires to achieve it. This is indeed harder in a decentralized system and requires re-encrypting the secrets. But, as we're using key-pair per service-account, this can be opt-in. E.g. users can decide which services require key rolling and which doesn't. Anyway, the flow requires some polishing - especially understanding what users needs (rotate all keys? only part of them?). I'll be happy to discuss it more!

@lizrice
Copy link
Contributor

lizrice commented Jul 18, 2019

Hi @omerlh, TOC discussed this project this week. We felt there needs to be an answer to the question of key rotation, but when you have that in place you are welcome to take it to SIG Security for their thoughts on whether Kamus should be approved for Sandbox.

@omerlh
Copy link
Author

omerlh commented Jul 21, 2019

Thanks for the update @lizrice! We just merged Soluto/kamus#241 which added support for automated key rotation which supported by GCP and AWS KMS. I see it as the first step toward a full solution.
One of the reasons I want Kamus to be part of the CNCF is feedback and community - I'm not sure how the full solution should look. For example, should we make it easy to re-encrypt existing values? Or just make it easy to rotate the keys? I'm sure there are other aspects I'm missing, and I'll be happy to hear more voices.

@jbeda jbeda added the new project A project new to the CNCF is being proposed label Oct 8, 2019
@omerlh
Copy link
Author

omerlh commented Feb 10, 2020

Hey folks, it's been more than a year since I opened this PR. Is this process supposed to take that long? Is there something I need to do?

@amye
Copy link
Contributor

amye commented Feb 18, 2020

SIG-Security would be the group to review this for inclusion.

@lizrice
Copy link
Contributor

lizrice commented Feb 24, 2020

@ultrasaurus @pragashj @dshaw please could SIG Security give us a recommendation?

@ultrasaurus
Copy link
Member

@omerlh thank you for pinging us! Since you submitted this PR, the TOC created the SIGs to parallelize the due diligence process, and recently documented an updated process here: https://github.com/cncf/toc/blob/master/process/project_proposals.adoc

I'm sorry your proposal didn't get into our queue earlier. I'll sync up with the other chairs and one of us will take a look at this PR and we'll likely have some questions for you!

@omerlh
Copy link
Author

omerlh commented Feb 25, 2020

Thank you! I'll be happy to help with any question or update the proposal if required :)

@amye
Copy link
Contributor

amye commented Jun 26, 2020

In the 6/23 TOC meeting to review sandbox projects, the TOC did not include this project in the sandbox.
Missing: a Code of Conduct
You are welcome to reapply through the Sandbox application form and the 6 month window to reapply doesn't apply here.

I will leave this PR open and watch for an application in.

@amye
Copy link
Contributor

amye commented Sep 8, 2020

Closing this out as we've now moved to the Sandbox application form.

@amye amye closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new project A project new to the CNCF is being proposed sandbox tag-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Kamus - Sandbox project
8 participants