Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-toto doc analysis and recommendations #200

Merged
merged 45 commits into from
Nov 27, 2023
Merged

Conversation

jbogarthyde
Copy link
Contributor

resolves: #163
This PR updates and replaces previous PR #190

jbogarthyde and others added 14 commits September 5, 2023 09:37
add doc assessment for initial review

Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Initial draft of new Analysis & Recommendations document for in-toto

Signed-off-by: Judy Bogart <[email protected]>
replaced by 0009-in-toto.md

Signed-off-by: Judy Bogart <[email protected]>
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved

6. Content creation process

6.1 The [read-the-docs site](https://in-toto.readthedocs.io/en/latest/) has an [Edit the Doc button](https://github.com/in-toto/in-toto/blob/develop/doc/source/index.rst). Instead of pointing directly to the source files, make the button point to a page with instructions for [doc contributors](https://github.com/in-toto/community/blob/main/CONTRIBUTING.md), and a link to the [governance policies](https://github.com/in-toto/community/blob/main/GOVERNANCE.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or remove the "Edit the Docs" button entirely. This seems like a very wiki-ish feature and I'm not sure it belongs in a formal documentation set, even if it does redirect to contributor instructions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to like the edit the docs button -- remember we're encouraging folks to participate. Opening an issue with a template explaining how best to make suggestions is probably a good thing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
assessments/0009-in-toto/in-toto-implementation.md Outdated Show resolved Hide resolved
jbogarthyde and others added 12 commits November 13, 2023 16:19
Signed-off-by: Judy Bogart <[email protected]>
move general intro to README

Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jbogarthyde! The content here is good, and I agree with the suggestions.

There are some formatting issues throughout that we should fix before merging.

I've not reviewed the issues file yet, i expect those are still a work in progress.

We should update links throughout - you can use https://github.com/jbogarthyde/CNCF-techdocs/tree/main/assessments/0009-in-toto as a deploy preview to check them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this file assessments/0009-in-toto/issues.md


These issues identify and classify tasks that contributors can undertake to establish a set of organized and navigable documents on the in-toto public website.

- [ ] Create **Doc home page**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feels like a heading.

if we use the - [ ] notation, the line will show up like a check box or a todo.

Here, i think we should format to mimic a github issue:

Title: title of the issue

Description:
body copy of the issue (in mark down format)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename this file assessments/0009-in-toto/survey-of-existing-doc.md

Comment on lines 23 to 25
- [Survey of existing documentation](../survey-of-existing-documentation) (as of September 2023)
- [Analysis](../in-toto-analysis.md)
- [Recommendations and implementation](../in-toto-implementation.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Survey of existing documentation](../survey-of-existing-documentation) (as of September 2023)
- [Analysis](../in-toto-analysis.md)
- [Recommendations and implementation](../in-toto-implementation.md)
- [Survey of existing documentation](./survey-of-existing-documentation.md) (as of September 2023)
- [Analysis](./in-toto-analysis.md)
- [Recommendations and implementation](./in-toto-implementation.md)


These documents are intended to recommend a direction for the ongoing development of technical documentation for the in-toto open source software (OSS) project. This effort is funded by the CNCF Foundation as part of its overall effort to incubate, grow, and graduate open source cloud native software projects. According to CNCF best practices guidelines, effective documentation is a prerequisite for program graduation.

The [CNCF-techdocs](https://github.com/cncf/CNCF-techdocs/tree/main) group is developing a process aimed at assisting cloud-native open-source projects with their documentation efforts. The process has three steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [CNCF-techdocs](https://github.com/cncf/CNCF-techdocs/tree/main) group is developing a process aimed at assisting cloud-native open-source projects with their documentation efforts. The process has three steps:
The [CNCF-techdocs](https://github.com/cncf/techdocs) group is developing a process aimed at assisting cloud-native open-source projects with their documentation efforts. The process has three steps:


## How to use this document

Readers interested only in actionable improvements can skip to the [implementation recommendations](../in-toto-implementation.md). For more context, read the recommendations for each of the three areas of analysis:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Readers interested only in actionable improvements can skip to the [implementation recommendations](../in-toto-implementation.md). For more context, read the recommendations for each of the three areas of analysis:
Readers interested only in actionable improvements can skip to the [implementation recommendations](./in-toto-implementation.md). For more context, read the recommendations for each of the three areas of analysis:

Comment on lines +35 to +39
- [Project documentation recommendations](./assessments#recommendations)

- [Contributor documentation recommendations](./assessments#recommendations-1)

- [Website recommendations](./assessments#recommendations-2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Project documentation recommendations](./assessments#recommendations)
- [Contributor documentation recommendations](./assessments#recommendations-1)
- [Website recommendations](./assessments#recommendations-2)
- [Project documentation recommendations](#recommendations)
- [Contributor documentation recommendations](#recommendations-1)
- [Website recommendations](#recommendations-2)

Comment on lines +43 to +47
- [Project documentation](./assessments#project-documentation-analysis)

- [Contributor documentation](./assessments#contributor-documentation-analysis)

- [Website](./assessments#website-analysis)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Project documentation](./assessments#project-documentation-analysis)
- [Contributor documentation](./assessments#contributor-documentation-analysis)
- [Website](./assessments#website-analysis)
- [Project documentation](#project-documentation-analysis)
- [Contributor documentation](#contributor-documentation-analysis)
- [Website](#website-analysis)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Somehow, there were not fixed. I've fixed them now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

| **Evaluators** determine whether in-toto meets their needs and can be implemented in their organization. | Good high-level technical overview w/marketing slant, analysis business benefits, adoption and success stories, and workflow overview. |
| **End users** can be *Project owners* and *Functionaries*. | End users can be new or experienced. New users need a clear learning path and general examples. Experienced users need reference docs and use-case examples. |
| **Project owner** defines the layout to be followed by, e.g. using the in-toto CLI tools. When doing so, they specify who is intended to sign for every piece of link metadata, any sublayouts that may exist, and how to further verify accompanying metadata. | New users need overview, demo, templates, basic instructions. Experienced users need deeper architectural info, use cases, examples. |
| **Functionaries** perform the intended actions and produce link metadata for each step. | *?? do these users read in-toto doc at all, or is the project owner responsible for instructing them in how to sign and verify their steps??* |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, asking the community folks who have been participating could help here.

Comment on lines 70 to 84
1. Create **Doc home page**

The landing page for the [read-the-docs site](https://in-toto.readthedocs.io/en/latest/), which currently lands on the auto-generated Python reference doc, could be expanded and repurposed as the new overall **Doc home page**.

1.1 To be immediately useful, the landing page should provide a *top-level roadmap* to existing docs. See [Survey of existing doc](https://github.com/jbogarthyde/CNCF-techdocs/main/assessments/0009-in-toto/survey-of-existing-doc.md)

This is a necessary step in raising the maturity level of this project. The roadmap should initially describe and provide access to:
- Specification
- Basic demo
- Python reference implementation along with its reference docs (which need to move into a sub-directory)
- Overview of the git repo structure.

1.2 Move the Description and pointer to the Python Reference implementation to an Implementations section, and move the RTD reference docs for it into this section.

1.3 Create a doc contributors policy requiring that the Doc home page be updated to reflect any changes to the doc locations and structure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fix the formatting issues

Suggested change
1. Create **Doc home page**
The landing page for the [read-the-docs site](https://in-toto.readthedocs.io/en/latest/), which currently lands on the auto-generated Python reference doc, could be expanded and repurposed as the new overall **Doc home page**.
1.1 To be immediately useful, the landing page should provide a *top-level roadmap* to existing docs. See [Survey of existing doc](https://github.com/jbogarthyde/CNCF-techdocs/main/assessments/0009-in-toto/survey-of-existing-doc.md)
This is a necessary step in raising the maturity level of this project. The roadmap should initially describe and provide access to:
- Specification
- Basic demo
- Python reference implementation along with its reference docs (which need to move into a sub-directory)
- Overview of the git repo structure.
1.2 Move the Description and pointer to the Python Reference implementation to an Implementations section, and move the RTD reference docs for it into this section.
1.3 Create a doc contributors policy requiring that the Doc home page be updated to reflect any changes to the doc locations and structure.
1. Create **Doc home page**
The landing page for the [read-the-docs site](https://in-toto.readthedocs.io/en/latest/), which currently lands on the auto-generated Python reference doc, could be expanded and repurposed as the new overall **Doc home page**.
1.1 To be immediately useful, the landing page should provide a *top-level roadmap* to existing docs. See [Survey of existing doc](https://github.com/jbogarthyde/CNCF-techdocs/main/assessments/0009-in-toto/survey-of-existing-doc.md)
This is a necessary step in raising the maturity level of this project. The roadmap should initially describe and provide access to:
- Specification
- Basic demo
- Python reference implementation along with its reference docs (which need to move into a sub-directory)
- Overview of the git repo structure.
1.2 Move the Description and pointer to the Python Reference implementation to an Implementations section, and move the RTD reference docs for it into this section.
1.3 Create a doc contributors policy requiring that the Doc home page be updated to reflect any changes to the doc locations and structure.

Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @jbogarthyde!

We can still make more if needed, but let's get this merged in as is so we can re-start the conversation with the community!

@nate-double-u nate-double-u merged commit 4172627 into cncf:main Nov 27, 2023
1 check failed
dwelsch-esi added a commit to dwelsch-esi/cncf-techdocs that referenced this pull request Nov 28, 2023
Adding in-toto doc assessment.

* Create 0009-iin-toto.md

add doc assessment for initial review

Signed-off-by: Judy Bogart <[email protected]>

* add definition of doc champion

Signed-off-by: Judy Bogart <[email protected]>

* clarify end-user types

Signed-off-by: Judy Bogart <[email protected]>

* Expand recommendations, user roles and doc needs

Signed-off-by: Judy Bogart <[email protected]>

* further clarify user roles

Signed-off-by: Judy Bogart <[email protected]>

* comment w/question on website status

Signed-off-by: Judy Bogart <[email protected]>

* updated the wesite section with appropriate info

Signed-off-by: thisisobate <[email protected]>

* Address review comments from TechDocs team

Signed-off-by: Judy Bogart <[email protected]>

* Expand and emphasize actionable recommendations

Signed-off-by: Judy Bogart <[email protected]>

* Consolidate recommendations, add doc structure summary

Signed-off-by: Judy Bogart <[email protected]>

* Expand and personalize introductory text

Signed-off-by: Judy Bogart <[email protected]>

* Create 0009-in-toto.md

Initial draft of new Analysis & Recommendations document for in-toto

Signed-off-by: Judy Bogart <[email protected]>

* Delete assessments/0009-iin-toto.md

replaced by 0009-in-toto.md

Signed-off-by: Judy Bogart <[email protected]>

* Add sources of existing doc

* reorganizing in-toto analyisis files

Signed-off-by: Nate W <[email protected]>

* Separate into analysis and implementation docs

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* move doc survey to separate file

Signed-off-by: Judy Bogart <[email protected]>

* Create survey-of-existing-doc

Signed-off-by: Judy Bogart <[email protected]>

* Resolve review comments

Signed-off-by: Judy Bogart <[email protected]>

* Add date of survey

Signed-off-by: Judy Bogart <[email protected]>

* Update README.md

Signed-off-by: Judy Bogart <[email protected]>

* adjust for new file structure

move general intro to README

Signed-off-by: Judy Bogart <[email protected]>

* make first section generally applicable

Signed-off-by: Judy Bogart <[email protected]>

* minor edit

Signed-off-by: Judy Bogart <[email protected]>

* point to survey and implementation docs

Signed-off-by: Judy Bogart <[email protected]>

* Update title

Signed-off-by: Judy Bogart <[email protected]>

* Propose documentation issues to encourage doc contributions

Signed-off-by: Judy Bogart <[email protected]>

* Apply suggestions from code review

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* minor edit

Signed-off-by: Judy Bogart <[email protected]>

* Update issues

Signed-off-by: Judy Bogart <[email protected]>

* Update and rename issues to in-toto-doc-issues.md

Signed-off-by: Judy Bogart <[email protected]>

* make issues more distinct

Signed-off-by: Judy Bogart <[email protected]>

* add link to proposed issues

Signed-off-by: Judy Bogart <[email protected]>

* fix links

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix filename

Signed-off-by: Judy Bogart <[email protected]>

* fix links

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix formats

Signed-off-by: Judy Bogart <[email protected]>

---------

Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: Nate W <[email protected]>
Co-authored-by: thisisobate <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
dwelsch-esi added a commit to dwelsch-esi/cncf-techdocs that referenced this pull request Nov 28, 2023
Adding in-toto doc assessment.

* Create 0009-iin-toto.md

add doc assessment for initial review

Signed-off-by: Judy Bogart <[email protected]>

* add definition of doc champion

Signed-off-by: Judy Bogart <[email protected]>

* clarify end-user types

Signed-off-by: Judy Bogart <[email protected]>

* Expand recommendations, user roles and doc needs

Signed-off-by: Judy Bogart <[email protected]>

* further clarify user roles

Signed-off-by: Judy Bogart <[email protected]>

* comment w/question on website status

Signed-off-by: Judy Bogart <[email protected]>

* updated the wesite section with appropriate info

Signed-off-by: thisisobate <[email protected]>

* Address review comments from TechDocs team

Signed-off-by: Judy Bogart <[email protected]>

* Expand and emphasize actionable recommendations

Signed-off-by: Judy Bogart <[email protected]>

* Consolidate recommendations, add doc structure summary

Signed-off-by: Judy Bogart <[email protected]>

* Expand and personalize introductory text

Signed-off-by: Judy Bogart <[email protected]>

* Create 0009-in-toto.md

Initial draft of new Analysis & Recommendations document for in-toto

Signed-off-by: Judy Bogart <[email protected]>

* Delete assessments/0009-iin-toto.md

replaced by 0009-in-toto.md

Signed-off-by: Judy Bogart <[email protected]>

* Add sources of existing doc

* reorganizing in-toto analyisis files

Signed-off-by: Nate W <[email protected]>

* Separate into analysis and implementation docs

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* Update assessments/0009-in-toto/in-toto-implementation.md

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* move doc survey to separate file

Signed-off-by: Judy Bogart <[email protected]>

* Create survey-of-existing-doc

Signed-off-by: Judy Bogart <[email protected]>

* Resolve review comments

Signed-off-by: Judy Bogart <[email protected]>

* Add date of survey

Signed-off-by: Judy Bogart <[email protected]>

* Update README.md

Signed-off-by: Judy Bogart <[email protected]>

* adjust for new file structure

move general intro to README

Signed-off-by: Judy Bogart <[email protected]>

* make first section generally applicable

Signed-off-by: Judy Bogart <[email protected]>

* minor edit

Signed-off-by: Judy Bogart <[email protected]>

* point to survey and implementation docs

Signed-off-by: Judy Bogart <[email protected]>

* Update title

Signed-off-by: Judy Bogart <[email protected]>

* Propose documentation issues to encourage doc contributions

Signed-off-by: Judy Bogart <[email protected]>

* Apply suggestions from code review

Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Judy Bogart <[email protected]>

* minor edit

Signed-off-by: Judy Bogart <[email protected]>

* Update issues

Signed-off-by: Judy Bogart <[email protected]>

* Update and rename issues to in-toto-doc-issues.md

Signed-off-by: Judy Bogart <[email protected]>

* make issues more distinct

Signed-off-by: Judy Bogart <[email protected]>

* add link to proposed issues

Signed-off-by: Judy Bogart <[email protected]>

* fix links

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix filename

Signed-off-by: Judy Bogart <[email protected]>

* fix links

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix link

Signed-off-by: Judy Bogart <[email protected]>

* fix formats

Signed-off-by: Judy Bogart <[email protected]>

---------

Signed-off-by: Judy Bogart <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: Nate W <[email protected]>
Co-authored-by: thisisobate <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: dwelsch-esi <[email protected]>
Signed-off-by: Dave Welsch <[email protected]>
c. Link **Getting Started** as the first menu item in the **Get started** menu (currently the first item is a link to a demo).

d. Expose parts of the product specification as separate named documents on the website, as:
- [System Overview](https://github.com/in-toto/docs/blob/master/in-toto-spec.md#2-system-overview) (compare content to https://in-toto.io/in-toto/README and current website About - create versions of increasing depth to address to specific audiences)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwelsch-esi the https://in-toto.io/in-toto/README link is invalid. What was it meant to be?

/cc @nate-double-u

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe @jbogarthyde was suggesting comparing and bringing the one in line with the other?

@nate-double-u nate-double-u added the Docs analysis CNCF technical documentation assistance label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs analysis CNCF technical documentation assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNCFSD-1517 in-toto website look
5 participants