Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

DCO Signoff for Template Repo #95

Open
2 tasks
nate-double-u opened this issue Jul 26, 2021 · 3 comments
Open
2 tasks

DCO Signoff for Template Repo #95

nate-double-u opened this issue Jul 26, 2021 · 3 comments

Comments

@nate-double-u
Copy link
Member

Problems:

  • Not all commits in cncf/hugo-netlify-starter are currently signed off using DCO.
  • When creating new repositories from the "Use this template" button, there is a single Initial commit created, which is not signed.

(Possible) fixes:

  • Go through and sign historic commits (though this isn't an issue for creating new repos from the template, unsigned commits can cause issues when pulling in upstream changes)
  • Add instructions to the starter (readme, or on the site itself), on how to setup DCO on new repositories, and provide a snippet to show how to sign the Initial commit
@celestehorgan
Copy link
Contributor

Re: Use this template creating an initial, unsigned commit.

Another workaround would be to use Hugo's prescribed theme import method (git submodule). Presumably this would pull in only signed commits.

@nate-double-u
Copy link
Member Author

Another workaround would be to use Hugo's prescribed theme import method (git submodule). Presumably this would pull in only signed commits.

Would that work with the site as is? Or would we need to "themeify" the starter in order to import it like that?
(I think I'm pro making the starter a theme, but there may be some related conversation over in #64)

@chalin
Copy link
Collaborator

chalin commented Jul 28, 2021

I think having our own CNCF theme might be very nice but, unfortunately, I don't believe that we have the resources to develop and maintain it. I'd vote for use of Docsy (#64).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants