-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing changes section of README is out of date #513
Comments
To update/add you affiliations you need to follow this. You can update instructions with changes suggested by creating a PR, I will review and approve/merge then. |
Will be doing the adding flow shortly. I tried the "run test" flow to see if it would give me any feedback before adding myself and noticed that it is no longer accurate. |
@lukaszgryglicki I will say the "what am I doing" and "why am I doing it" aspect of the add yourself flow is very cryptic. For example, the phrase "We need historical emails to track historical data" probably makes sense to someone, but as a new person I'm already confused seeing the list of dev1, dev2, dev3, dev4, dev5, etc docs and trying to figure out what they mean and why they are structured the way they are. It is also unclear to me why they are so repetitive, the same names appear across multiple files with similar stanzas. It's not clear if someone is to add themselves just to the doc with the largest number, or if they are to add themselves to multiple documents. I can also intuit that an email address is of the structure |
You are very welcomed to propose changes to |
The confusing thing is that it isn't clear where to make a new entry.
|
I'll cite this comment on PR as another example of the confusion: The image is humorous. 🐶 😄 I also commented on this PR that the dev seemed to have edited files that the README indicates are generated, not for human editing. |
I can TAL on Friday the earliest, developers* files are sorted alphabetically and lower/UPPER letters are in separate (case sensitive) - usually there is no issue if somebody makes a typo or just adds entry at the end - as I usually update/regenerate this files after other internals tasks, or after merging a bunch of PRs. This wasn't really an issue for me, no matter what people contribute in PRs - I'm usually merging and then correcting in post-merge instead of asking people to fix their PRs. |
I've merged your PR. Thanks for your feedback. |
The
Testing changes
section of the README is out of date:At minimum, this
./rerun_data.sh
file is now./src/rerun_data.sh
.I'm new, attempting to follow the instructions here as requested from the Kubernetes Community Membership document. There may be
other items out of date, I'll either update this issue as I go, or create new issues if unrelated.
The text was updated successfully, but these errors were encountered: