-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert theme options to theme.json #449
Comments
Here's our WIP theme.json file for any future reference:
|
"its not a bug, it's a feature" is the WP line. So we won't be using theme.json to control the theme until we redesign. |
Let me see if I'm understanding the above conversation correctly. Here's what I think I understand, and I hope I'm wrong...
Am I missing something? Does this mean that as soon as I want my theme to start supporting a feature that depends on declaring theme.json, I suddenly lose any ability for my theme to make behavioral decisions at runtime? Please tell me I've misunderstood. |
Hey @sdwire let me see if I can help you out
This is why for the CNCF website, which runs on WordPress and uses the Block Editor, there are several styles and layouts that cannot be replicated with theme.json as show above (as it stood the last I looked at it). We are currently redesigning the site (a coincidence) and that "should" allow us to use theme.json. We'll find out in the coming weeks! |
Sounds like we are not going this route with our new theme so will close |
WP5.8 started to use theme.json to control block editor options. This should remove much of the Gutenberg options from the theme and allow for granular control of settings per block.
However the way it works is not compatible with our current design and layout.
add_theme_support( 'align-wide' )
is set)Our group layouts look like this using theme.json
The new group inner layout options
Using the default layout option for a group generates inline CSS which centres all content (see Latest news... title)
To adopt the theme.json option we need to either:
add_theme_support( 'align-wide' )
being recognised when using theme.json and we can continue using our current layoutAnother approach that fails:
Related issue on Github
WordPress/gutenberg#33374
Related on Trac
https://core.trac.wordpress.org/ticket/53563
https://core.trac.wordpress.org/ticket/53748
The text was updated successfully, but these errors were encountered: