remove usage of github.com/hashicorp/go-multierror #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
force-pushed
the
error-dependencies
branch
3 times, most recently
from
81a5a0f to
b9a62f2
Compare
|
@pohly the dependency seems to be still present as indirect, is that expected? Second question, is |
The internal replacement is a simpler implementation which only supports enough functionality for the places where github.com/hashicorp/go-multierror was used before. Not depending on github.com/hashicorp/go-multierror and thus github.com/hashicorp/errwrap makes it easier to use CDI in Kubernetes because we don't need to add those other dependencies. Signed-off-by: Patrick Ohly <[email protected]>
Yes: github.com/opencontainers/runtime-tools would have to be modified to get rid of it completely. May be useful, but doesn't affect us that much because it doesn't get pulled into Kubernetes (I checked).
Oops, no. Looks like I was relying on Go projects filtering out "*.test" during |
pohly
force-pushed
the
error-dependencies
branch
from
b9a62f2 to
ec52f5a
Compare
|
ok. if that is not propagating to k8s as import, then it is lgtm from me. |
elezar
approved these changes
Nov 3, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal replacement is a simpler implementation which only supports enough functionality for the places where github.com/hashicorp/go-multierror was used before.
Not depending on github.com/hashicorp/go-multierror and thus github.com/hashicorp/errwrap makes it easier to use CDI in Kubernetes because we don't need to add those other dependencies.
Fixes: #88