-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced incorrect link #167
Conversation
Signed-off-by: Atreay Kukanur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Are there any other links?
Also, the consumption of the go package may require that we update the go module.
@@ -1,6 +1,6 @@ | |||
# CDI - The Container Device Interface | |||
|
|||
**NOTE:** The API for injecting CDI devices that existed at `github.com/container-orchestrated-devices/container-device-interface/pkg` has been removed. Users of this API should migrate to the one at `github.com/container-orchestrated-devices/container-device-interface/pkg/cdi` as this is actively maintained. | |||
**NOTE:** The API for injecting CDI devices that existed at `github.com/container-orchestrated-devices/container-device-interface/pkg` has been removed. Users of this API should migrate to the one at `https://github.com/cncf-tags/container-device-interface/tree/main/pkg/cdi` as this is actively maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will require that we update the go module too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Elezar, I couldn't locate any other links. Could you please clarify which module we need to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created #172 to switch to the shortened URL.
Hey @elezar, I'm a bit stuck here and couldn't find any additional links. Could you provide some clarity on which specific module we should be updating? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ATREAY.
I'm going to merge this and address the remaining changes in a follow-up.
This pull request is related to issue #157(Links in note are incorrect)