codespell: workflow, config, typos fixed #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
previously approved these changes
May 4, 2023
elezar
reviewed
May 4, 2023
.codespellrc
Outdated
| @@ -0,0 +1,4 @@ | |||
| [codespell] | |||
| skip = .git,*.pdf,*.svg | |||
| # BU - part of JP3t17pCcGlemwknint6hfoeCVQrEMVwxRLRjXpq+BU= | |||
There was a problem hiding this comment.
@yarikoptic as someone who is not too familiar with codespell what does this represent?
There was a problem hiding this comment.
in this comment I am listing why we need to exclude BU -- you can find it by the end of that string and you have this string in the codebase somewhere.
There was a problem hiding this comment.
This string is in a go.sum file. Does it not make more sense to add *.sum to the skip list?
|
/lgtm |
|
merged |
elezar
requested changes
May 8, 2023
.codespellrc
Outdated
| @@ -0,0 +1,4 @@ | |||
| [codespell] | |||
| skip = .git,*.pdf,*.svg | |||
| # BU - part of JP3t17pCcGlemwknint6hfoeCVQrEMVwxRLRjXpq+BU= | |||
There was a problem hiding this comment.
This string is in a go.sum file. Does it not make more sense to add *.sum to the skip list?
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
Signed-off-by: Yaroslav Halchenko <[email protected]>
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Signed-off-by: Yaroslav Halchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While listening to @elezar giving a presentation, decided to check the CDI out: Having typos free code would be very useful for 1.0 release ;)