Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: remove github.com/hashicorp/go-multierror and github.com/hashicorp/errwrap #88

Closed
pohly opened this issue Nov 1, 2022 · 0 comments · Fixed by #89
Closed

dependencies: remove github.com/hashicorp/go-multierror and github.com/hashicorp/errwrap #88

pohly opened this issue Nov 1, 2022 · 0 comments · Fixed by #89

Comments

@pohly
Copy link
Contributor

pohly commented Nov 1, 2022

Using CDI in Kubernetes adds two new dependencies:

$ go mod why -m github.com/hashicorp/go-multierror
# github.com/hashicorp/go-multierror
k8s.io/kubernetes/pkg/kubelet/cm/dra
github.com/container-orchestrated-devices/container-device-interface/pkg/cdi
github.com/hashicorp/go-multierror

$ go mod why -m github.com/hashicorp/errwrap
# github.com/hashicorp/errwrap
k8s.io/kubernetes/pkg/kubelet/cm/dra
github.com/container-orchestrated-devices/container-device-interface/pkg/cdi
github.com/hashicorp/go-multierror
github.com/hashicorp/errwrap

Can those two dependencies be removed? Go natively has support for wrapping errors and combining multiple multiple errors into one can be implemented with custom code instead of dragging in a dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove usage of github.com/hashicorp/go-multierror pohly/container-device-interface
1 participant
@pohly