Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetRegistry should not reconfigure registry on every call #132

Closed
elezar opened this issue Mar 22, 2023 · 3 comments
Closed

GetRegistry should not reconfigure registry on every call #132

elezar opened this issue Mar 22, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@elezar
Copy link
Contributor

elezar commented Mar 22, 2023

See moby/moby#45134 (comment) and moby/moby#45134 (comment)

@elezar elezar added the bug Something isn't working label Mar 22, 2023
@elezar elezar changed the title GetRegistry should not reconfigure registru on every call GetRegistry should not reconfigure registry on every call Mar 22, 2023
Copy link

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

@elezar
Copy link
Contributor Author

elezar commented Jun 7, 2024

@klihub I think this has been addressed by your most recent refactoring changes from #192

Please close this if this is the case.

@klihub
Copy link
Contributor

klihub commented Jun 7, 2024

@klihub I think this has been addressed by your most recent refactoring changes from #192

Please close this if this is the case.

With those changes in place, GetRegistry() is now a GetDefaultCache() + and optional call to Cache.Configure() on the default cache instance. It only ends up calling Configure() if there are options passed to it. It is not smart about the options themselves, though. If you call it twice in a row with the same options, it will call Configure() both times. But this should be good enough to address the main complains in the above linked moby PRs. So closing this.

@klihub klihub closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants