Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relocation of invocation images #158

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Support relocation of invocation images #158

merged 2 commits into from
Apr 11, 2019

Conversation

glyn
Copy link
Contributor

@glyn glyn commented Apr 11, 2019 •
edited
Loading

Fixes #157

@glyn glyn mentioned this pull request Apr 11, 2019
Merged
@glyn glyn force-pushed the 157-invocation-image-relocation branch from cc9db5b to 662dd8a Compare April 11, 2019 15:23
@glyn
Support relocation of invocation images
999cd49 
Fixes cnabio#157
@glyn
Rip out originalDigest
f551bef 
The consensus was that image relocation should not modify the (content) digest.
@glyn glyn force-pushed the 157-invocation-image-relocation branch from 662dd8a to f551bef Compare April 11, 2019 15:28
technosophos
technosophos approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

radu-matei
radu-matei approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michelleN michelleN merged commit 5ef82e3 into cnabio:master Apr 11, 2019
@glyn glyn deleted the 157-invocation-image-relocation branch April 11, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radu-matei radu-matei radu-matei approved these changes

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glyn @technosophos @radu-matei @michelleN