Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relocation of invocation images #157

Closed
glyn opened this issue Apr 11, 2019 · 2 comments
Closed

Support relocation of invocation images #157

glyn opened this issue Apr 11, 2019 · 2 comments

Comments

@glyn
Copy link
Contributor

glyn commented Apr 11, 2019

In some scenarios, such as deploying a thick bundle in an air-gapped system, the runtime needs to relocate invocation images (as well as the other images referenced by the bundle). To support this, the optional originalImage and originalDigest fields should be added to invocation images.
@glyn glyn mentioned this issue Apr 11, 2019
Closed
glyn added a commit to glyn/cnab-spec that referenced this issue Apr 11, 2019
@glyn
Support relocation of invocation images
cc9db5b 
Fixes cnabio#157
@glyn glyn mentioned this issue Apr 11, 2019
Merged
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
dbad895 
See `duffle relocate -h` for documentation.

Adds the originalImage and originalDigest fields to images in both the image
map and invocation images on the assumption that
cnabio/cnab-spec#157 will be implemented.

Fixes cnabio#668
@glyn glyn mentioned this issue Apr 11, 2019
Merged
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
1a328c5 
See `duffle relocate -h` for documentation.

Adds the originalImage and originalDigest fields to images in both the image
map and invocation images on the assumption that
cnabio/cnab-spec#157 will be implemented.

Fixes cnabio#668
@simonferquel
Copy link
Contributor

same as for images, the digest should not change because of relocation. If it does, it means that the content of the image itself has changed

@glyn
Copy link
Contributor Author

glyn commented Apr 11, 2019

same as for images, the digest should not change because of relocation. If it does, it means that the content of the image itself has changed

I agree with the sentiment, but please note that if the digest changes because a registry-specific compression algorithm was used, then it is conceivable for the uncompressed image content not to have changed even though the digest has.

The image relocation code preserves digests by carefully copying blobs between registries without changing their compression.

glyn added a commit to glyn/cnab-spec that referenced this issue Apr 11, 2019
@glyn
Support relocation of invocation images
b62cdf0 
Fixes cnabio#157
glyn added a commit to glyn/cnab-spec that referenced this issue Apr 11, 2019
@glyn
Support relocation of invocation images
999cd49 
Fixes cnabio#157
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
cedf200 
See `duffle relocate -h` for documentation.

Adds the originalImage field to images in both the image map and invocation
images on the assumption that cnabio/cnab-spec#157
will be implemented.

Fixes cnabio#668
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
60e5416 
See `duffle relocate -h` for documentation.

Adds the originalImage field to images in both the image map and invocation
images on the assumption that cnabio/cnab-spec#157
will be implemented.

Fixes cnabio#668
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
59432c8 
See `duffle relocate -h` for documentation.

Adds the originalImage field to images in both the image map and invocation
images on the assumption that cnabio/cnab-spec#157
will be implemented.

Fixes cnabio#668
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
912bea9 
See `duffle relocate -h` for documentation.

Adds the originalImage field to images in both the image map and invocation
images on the assumption that cnabio/cnab-spec#157
will be implemented.

Fixes cnabio#668
glyn added a commit to glyn/duffle that referenced this issue Apr 11, 2019
@glyn
Image relocation
44b874b 
See `duffle relocate -h` for documentation.

Adds the originalImage field to images in both the image map and invocation
images on the assumption that cnabio/cnab-spec#157
will be implemented.

Fixes cnabio#668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glyn @simonferquel