Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount entire bundle.json as a file at /var/run/cnab/bundle.json #144

Closed
technosophos opened this issue Mar 20, 2019 · 5 comments
Closed

Mount entire bundle.json as a file at /var/run/cnab/bundle.json #144

technosophos opened this issue Mar 20, 2019 · 5 comments
Assignees
@youreddy
Labels
enhancement New feature or request
Milestone
CNAB Core 1.0.0

Comments

@technosophos
Copy link
Member

In the first few drafts of the CNAB spec, the bundle.json was accessible inside of the invocation image (as part of the building process, it was copied in). We removed that when we lowered the requirements for building a bundle.

Now, there are several different pieces of the bundle.json that are interesting to authors of invocation images. Should we just require that the bundle.json be mounted at a fixed location (/var/run/cnab/bundle.json, for example)?
@technosophos technosophos added the enhancement New feature or request label Mar 20, 2019
@technosophos technosophos mentioned this issue Mar 21, 2019
Closed
@glyn
Copy link
Contributor

glyn commented Mar 25, 2019

Yes, I think this is a great idea. I can't see any downside. In particular, this approach would solve #143 by allowing invocation images to see custom extensions. It would also simplify the runtime by avoiding it having to treat several pieces of bundle.json similarly.

@simonferquel
Copy link
Contributor

Agreed!

@simonferquel
Copy link
Contributor

cc @silvin-lubecki, we need to track this for docker-app (it will change the way we need to extract the image map in the run tool).

This was referenced Apr 16, 2019
Closed
Closed
@jeremyrickard jeremyrickard added this to the 1.0.0 milestone Jun 6, 2019
@glyn glyn mentioned this issue Jun 12, 2019
Closed
@youreddy youreddy mentioned this issue Jun 13, 2019
Merged
@glyn
Copy link
Contributor

glyn commented Jun 13, 2019

@youreddy You are working on a PR to fix this issue, so I took the liberty of assigning this issue to you. Please unassign if that's not appropriate.

@glyn glyn mentioned this issue Jun 17, 2019
Closed
jeremyrickard pushed a commit that referenced this issue Jun 18, 2019
@glyn @jeremyrickard
Add bundle.json file to invocation image (#196)
8e47d92 
* Add bundle.json file to invocation image

- Addresses issue #144

* Update 100-CNAB.md

Co-Authored-By: Glyn Normington <[email protected]>

* Update 100-CNAB.md

Co-Authored-By: Glyn Normington <[email protected]>
@jeremyrickard
Copy link
Member

Closed by #196

@astrieanna astrieanna mentioned this issue Jun 19, 2019
Closed
astrieanna pushed a commit to astrieanna/cnab-spec that referenced this issue Jun 21, 2019
@astrieanna
Add bundle.json file to invocation image
24e7cd2 
- Addresses issue cnabio#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youreddy youreddy

Labels
enhancement New feature or request
Projects
None yet
Milestone
CNAB Core 1.0.0
Development

No branches or pull requests
5 participants
@technosophos @glyn @simonferquel @youreddy @jeremyrickard