Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge/test issue211_new_oio branch #221

Closed
edmcman opened this issue May 10, 2022 · 2 comments
Closed

Merge/test issue211_new_oio branch #221

edmcman opened this issue May 10, 2022 · 2 comments

Comments

@edmcman
Copy link
Contributor

edmcman commented May 10, 2022

Make sure we merge this:

I added a new rule that is very simple. It says that if a method install the same VFTable at two offsets, then the VFTable's object is contained at both offsets. As a result, the method and VFTable can't be on the same class.

This seems pretty obvious and I'm not sure why we didn't have this as a rule. Maybe because we didn't always have VFTable's as a separate object, we couldn't express this in the past and then just never added it?

Anyway, running again to see if this helps.

Originally posted by @sei-eschwartz in #211 (comment)

@edmcman edmcman changed the title New OIO rule New OIO rule from issue211 branch May 10, 2022
@sei-eschwartz sei-eschwartz self-assigned this May 10, 2022
@sei-eschwartz sei-eschwartz changed the title New OIO rule from issue211 branch Merge/test issue211_oio branch Jun 14, 2022
@sei-eschwartz sei-eschwartz changed the title Merge/test issue211_oio branch Merge/test issue211_new_oio branch Jun 14, 2022
@sei-eschwartz
Copy link
Collaborator

Can this be merged now?

@sei-eschwartz
Copy link
Collaborator

This is already merged internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants