Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: vftables are needed for each class inherited in its hierarchy, not just immediate bases #207

Closed
sei-eschwartz opened this issue Jan 13, 2022 · 2 comments
Assignees

Comments

@sei-eschwartz
Copy link
Collaborator

There is a bug in reasonVFTableBelongsToClass: https://github.com/cmu-sei/pharos/blob/master/share/prolog/oorules/rules.pl#L947

The problem is that a class needs a vftable for each class inherited in its hierarchy. So if class A inherits from B, which inherits from C and D, then A needs at least two vftables, even though it only directly inherits from one class.

This first came to light in #187.

@sei-eschwartz sei-eschwartz self-assigned this Jan 13, 2022
@sei-eschwartz sei-eschwartz changed the title Bug in reasonVFTableBelongsToClass bug: vftables are needed for each class inherited in its hierarchy, not just immediate bases Mar 18, 2022
@sei-eschwartz
Copy link
Collaborator Author

This is resolved in #214

@edmcman
Copy link
Contributor

edmcman commented Aug 11, 2022

% Constructors may inline embedded constructors. If non-offset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants