Updating particle ids for lambdas #15

alberto-sanchez · 2020-10-14T20:51:11Z

Making lambda's ids compatible with pythia 8.3

cmsbuild · 2020-10-14T20:51:36Z

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for branch master.

@SiewYan, @smuzaffar, @mkirsano, @mrodozov, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
cms-bot commands are listed here

alberto-sanchez · 2020-10-15T02:31:58Z

This should fix the issue in cms-sw/cmsdist#6286 with the update of pythia to 8.3

cmsbuild · 2020-10-15T08:20:39Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6286

CMSSW_11_2_X_2020-10-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9983/console Started: 2020/10/15 18:41

cmsbuild · 2020-10-15T18:59:44Z

-1

Tested at: b352975

CMSSW: CMSSW_11_2_X_2020-10-15-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fb10d/9983/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test testTauEmbeddingProducers had ERRORS

cmsbuild · 2020-10-15T18:59:47Z

Comparison job queued.

cmsbuild · 2020-10-16T01:16:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fb10d/9983/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 43340 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2541536
DQMHistoTests: Total failures: 472751
DQMHistoTests: Total nulls: 172
DQMHistoTests: Total successes: 2068591
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1109.497 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.625 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11634.0,... ): -555.274 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 250202.181 ): 0.543 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.117 KiB SiStrip/MechanicalView
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-10-16T07:06:33Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6286,cms-sw/cmssw#31816

CMSSW_11_2_X_2020-10-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10003/console Started: 2020/10/16 09:09

cmsbuild · 2020-10-16T10:12:47Z

-1

Tested at: b352975

CMSSW: CMSSW_11_2_X_2020-10-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

#31772 @jalimena: fix for displaced susy relval production (TRK and EXO validation of displaced tracks)
#31792 @Dr15Jones: Removed use of boost::any in edmNew::DetSetVector
#31804 @ianna: [DD] remove unused headers
#31774 @bsunanda: Phase2-hgx264x Correct a small issue in HGCalGeometry and update some test codes

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10003/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10003/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10003/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test GeneratorInterfaceEvtGenInterfaceTest had ERRORS
---> test testTauEmbeddingProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

#31772 @jalimena: fix for displaced susy relval production (TRK and EXO validation of displaced tracks)
#31792 @Dr15Jones: Removed use of boost::any in edmNew::DetSetVector
#31804 @ianna: [DD] remove unused headers
#31774 @bsunanda: Phase2-hgx264x Correct a small issue in HGCalGeometry and update some test codes

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10003/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10003/git-merge-result

cmsbuild · 2020-10-16T10:12:51Z

Comparison job queued.

cmsbuild · 2020-11-04T07:41:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfcce0/10478/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 43244 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2541876
DQMHistoTests: Total failures: 474859
DQMHistoTests: Total nulls: 172
DQMHistoTests: Total successes: 2066823
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1109.497 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.625 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11634.0,... ): -555.274 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 250202.181 ): 0.543 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.117 KiB SiStrip/MechanicalView
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-11-10T11:29:02Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6286,cms-sw/cmssw#31816,cms-sw/cmssw#32077

CMSSW_11_2_X_2020-11-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10612/console Started: 2020/11/10 13:29

cmsbuild · 2020-11-10T15:04:39Z

+1
Tested at: 206c0d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44598f/10612/summary.html
CMSSW: CMSSW_11_2_X_2020-11-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-10T15:04:46Z

Comparison job queued.

cmsbuild · 2020-11-10T19:21:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44598f/10612/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 43268 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2527080
DQMHistoTests: Total failures: 476269
DQMHistoTests: Total nulls: 172
DQMHistoTests: Total successes: 2050617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1109.497 KiB( 34 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.625 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11634.0,... ): -555.274 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 250202.181 ): 0.543 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.117 KiB SiStrip/MechanicalView
Checked 148 log files, 22 edm output root files, 35 DQM output files

smuzaffar · 2020-11-12T12:50:49Z

So, are we happy with this update? If yes then can you please sign so that we can merge and create a cmsdist PR to go with cms-sw/cmsdist#6286

agrohsje · 2020-11-12T12:57:44Z

+1

smuzaffar · 2020-11-12T12:58:22Z

+externals

cmsbuild · 2020-11-12T12:58:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

alberto-sanchez added 2 commits October 14, 2020 15:42

updating pids for lambda in agreement with pythia 8.3

c24568d

missing one id

b352975

cmsbuild added comparison-pending externals-pending generators-pending orp-pending pending-signatures tests-pending labels Oct 14, 2020

mrodozov mentioned this pull request Oct 15, 2020

upgrade pythia8 to 303 cms-sw/cmsdist#6286

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Oct 15, 2020

cmsbuild added tests-rejected and removed tests-started labels Oct 15, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 16, 2020

alberto-sanchez mentioned this pull request Oct 16, 2020

trying to match pythia 8.303 cms-sw/cmssw#31816

Merged

cmsbuild added tests-started and removed tests-rejected labels Oct 16, 2020

cmsbuild removed comparison-available tests-started labels Oct 16, 2020

cmsbuild added comparison-pending tests-rejected labels Nov 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 4, 2020

cmsbuild mentioned this pull request Nov 10, 2020

Protect against empty weight container from pythia8 cms-sw/cmssw#32077

Merged

cmsbuild added tests-started and removed tests-rejected labels Nov 10, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

cmsbuild added generators-approved and removed generators-pending labels Nov 12, 2020

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Nov 12, 2020

smuzaffar merged commit 02b9703 into cms-data:master Nov 12, 2020

cmsbuild mentioned this pull request Nov 12, 2020

Update tag for GeneratorInterface-EvtGenInterface to V02-01-00 cms-sw/cmsdist#6411

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating particle ids for lambdas #15

Updating particle ids for lambdas #15

alberto-sanchez commented Oct 14, 2020

cmsbuild commented Oct 14, 2020

alberto-sanchez commented Oct 15, 2020 •

edited

Loading

cmsbuild commented Oct 15, 2020 •

edited

Loading

cmsbuild commented Oct 15, 2020

cmsbuild commented Oct 15, 2020

cmsbuild commented Oct 16, 2020

cmsbuild commented Oct 16, 2020 •

edited

Loading

cmsbuild commented Oct 16, 2020

cmsbuild commented Oct 16, 2020

cmsbuild commented Nov 4, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

smuzaffar commented Nov 12, 2020

agrohsje commented Nov 12, 2020

smuzaffar commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

Updating particle ids for lambdas #15

Updating particle ids for lambdas #15

Conversation

alberto-sanchez commented Oct 14, 2020

cmsbuild commented Oct 14, 2020

alberto-sanchez commented Oct 15, 2020 • edited Loading

cmsbuild commented Oct 15, 2020 • edited Loading

cmsbuild commented Oct 15, 2020

cmsbuild commented Oct 15, 2020

cmsbuild commented Oct 16, 2020

cmsbuild commented Oct 16, 2020 • edited Loading

cmsbuild commented Oct 16, 2020

cmsbuild commented Oct 16, 2020

cmsbuild commented Nov 4, 2020

cmsbuild commented Nov 10, 2020 • edited Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

smuzaffar commented Nov 12, 2020

agrohsje commented Nov 12, 2020

smuzaffar commented Nov 12, 2020

cmsbuild commented Nov 12, 2020

alberto-sanchez commented Oct 15, 2020 •

edited

Loading

cmsbuild commented Oct 15, 2020 •

edited

Loading

cmsbuild commented Oct 16, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020 •

edited

Loading