Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated EDAnalyzer in /CalibTracker/SiStripLorentzAngle #29

Closed
tvami opened this issue Sep 16, 2021 · 5 comments · Fixed by cms-sw/cmssw#35381
Closed

Deprecated EDAnalyzer in /CalibTracker/SiStripLorentzAngle #29

tvami opened this issue Sep 16, 2021 · 5 comments · Fixed by cms-sw/cmssw#35381
Assignees

Comments

@tvami
Copy link
Contributor

tvami commented Sep 16, 2021

The static analyzer shows that the strips LA is using some deprecated edm::EDAnalyzer here
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-804797/18395/llvm-analysis/

Deprecated API	inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule	/CalibTracker/SiStripLorentzAngle/interface/SiStripLAProfileBooker.h	SiStripLAProfileBooker	33	1	View Report
Deprecated API	inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule	/CalibTracker/SiStripLorentzAngle/plugins/EnsembleCalibrationLA.h	EnsembleCalibrationLA	10	1	View Report
Deprecated API	inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule	/CalibTracker/SiStripLorentzAngle/interface/SiStripLAProfileBooker.h	SiStripLAProfileBooker	33	1	View Report
Deprecated API	inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule	/CalibTracker/SiStripLorentzAngle/plugins/EnsembleCalibrationLA.h	EnsembleCalibrationLA	10	1	View Report
@tvami
Copy link
Contributor Author

tvami commented Sep 17, 2021

@FlorianBury could you please pass this to the conveners?

@FlorianBury
Copy link

@mdelcourt, @robervalwalsh : probably old code to be removed

@robervalwalsh
Copy link

@tvami, @FlorianBury, thanks! I understand those codes are deprecated. They could be removed.

@mmusich
Copy link
Contributor

mmusich commented Sep 22, 2021

@robervalwalsh if these codes are not necessary, please open a PR that removes them.

@mmusich
Copy link
Contributor

mmusich commented Sep 23, 2021

Addressed here: cms-sw/cmssw#35381 (if these are not needed they can be removed later)

@mmusich mmusich self-assigned this Sep 23, 2021
@tvami tvami closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants