New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return EMPTY_INDEX when server responds with error. #91

Merged

cmfcmf merged 2 commits into cmfcmf:main from jafin:fix/invalid-index-response

Jan 19, 2022

Contributor

jafin commented Jan 18, 2022

When a server responds with a not ok response (ie 500), index parsing is attempted and fails with

TypeError: Cannot read properties of undefined (reading 'fieldVectors')

This adds a guard for error response and returns the EMPTY_INDEX instead.
Relates to #85

jafin added 2 commits

January 18, 2022 16:22


          fix: Return EMPTY_INDEX when server responds with error.

2145be1


          fix: Return EMPTY_INDEX when server responds with error.

215de7e

Owner

cmfcmf commented Jan 19, 2022

Thanks a lot!

cmfcmf merged commit 1a4d89c into cmfcmf:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet