-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
64-Bit NODE.EXE linked in all builds with electron 5.0.0-beta.5 #163
Comments
Just realized this is because of the node.lib we are linking against from the official electron mirror, we can keep this ticket open for tracking but can not do anything about it in cmake-js Here is the link to the ticket in the electron project electron/electron#17326 |
Please try with v5.2.0 and let me know the result. |
Please test with 5.2.2+ |
I mean 5.3.2 |
It sounds like this was fixed in the releases menioned above |
First off, thank you very much for this useful project! For cross platform with a Raspberry Pi I needed to update from cmake-js 4.0.1 to 5.1.0 and from electron 3.0.3 to 5.0.0-beta.5 which worked like a charm on RPi and Ubuntu.
Now when I compile on Windows with VS2017 I first have to patch #160 and then my .node file links against NODE.EXE which most likely is no problem with normal node processes but it is with electron. Now I can more or less work around it like described in this comment nodejs/node-addon-api#269 (comment) but I don't think it is a nice solution and it does not work properly for ia32 arch because the DLL still tries to load a 64-Bit NODE.EXE
The text was updated successfully, but these errors were encountered: