Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove 'status_bar_' config prefixes #4

Merged
merged 2 commits into from
Apr 16, 2020
Merged

cleanup: Remove 'status_bar_' config prefixes #4

merged 2 commits into from
Apr 16, 2020

Conversation

cmacrae
Copy link
Owner

@cmacrae cmacrae commented Apr 16, 2020

Hey @somdoron 👋 Thanks for statusbar! I'd been looking to do the same thing, so I was delighted when someone pointed me to your repo.

I figured as this project is now simply a status bar on its own, the
status_bar_ prefix on all config options seemed superfluous :)

So, hopefully this simple cleanup is a welcomed change

cmacrae added 2 commits April 16, 2020 10:18
As this project is now simply a status bar on its own, the
'status_bar_' prefix on all config options seemed superfluous :)
@cmacrae
Copy link
Owner Author

cmacrae commented Apr 16, 2020

Noticed the manpage didn't include the clock_format option, so figured I'd make man and include it here 🙃

I can squash my commits if you'd prefer

@somdoron somdoron merged commit 1d05218 into cmacrae:master Apr 16, 2020
@somdoron
Copy link
Collaborator

Thanks!

@somdoron
Copy link
Collaborator

For the three people that already use this, we might want to have a backwards compatiblity?
We can even not document it, just accept anything that prefixed with status_bar_

@cmacrae cmacrae deleted the cleanup/remove_status_bar_prefix branch April 17, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants