From dc54a5b2a0cf8c4a7a90bddac777f63e520990d6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20L=C3=BCck?= <christian@clue.engineering>
Date: Fri, 7 Oct 2022 19:27:02 +0200
Subject: [PATCH] Test on PHP 8.2 and update test environment

---
 .github/workflows/ci.yml | 5 +++--
 phpunit.xml.dist         | 6 +++++-
 src/Factory.php          | 2 +-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6355356..9cb2ffd 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -11,9 +11,10 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-20.04
-          - windows-2019
+          - ubuntu-22.04
+          - windows-2022
         php:
+          - 8.2
           - 8.1
           - 8.0
           - 7.4
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 1b8eb6a..93827ff 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -5,7 +5,8 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true"
-         cacheResult="false">
+         cacheResult="false"
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="SQLite React Test Suite">
             <directory>./tests/</directory>
@@ -17,4 +18,7 @@
             <directory>./src/</directory>
         </include>
     </coverage>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/src/Factory.php b/src/Factory.php
index 5710522..655e2bb 100644
--- a/src/Factory.php
+++ b/src/Factory.php
@@ -433,7 +433,7 @@ private function php()
 
         // if `php` is a symlink to the php binary, use the shorter `php` name
         // this is purely cosmetic feature for the process list
-        if ($binary !== 'php' && \realpath($this->which('php')) === $binary) {
+        if ($binary !== 'php' && \realpath((string) $this->which('php')) === $binary) {
             $binary = 'php';
         }