From a95c593f54f7e11c3ae73107dfe81bfb3a0ac795 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20L=C3=BCck?= <christian@lueck.tv>
Date: Wed, 30 May 2018 07:47:40 +0200
Subject: [PATCH] Improve test suite by testing against PHP 7.2 and fix risky
 tests

---
 .travis.yml              | 1 +
 tests/ClientTest.php     | 3 +++
 tests/FactoryTest.php    | 3 +++
 tests/FunctionalTest.php | 4 ++++
 4 files changed, 11 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 3ace5ff..040ea31 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,6 +7,7 @@ php:
   - 5.6
   - 7.0
   - 7.1
+  - 7.2
   - hhvm # ignore errors, see below
 
 # lock distro so new future defaults will not break the build
diff --git a/tests/ClientTest.php b/tests/ClientTest.php
index c410e03..06478fc 100644
--- a/tests/ClientTest.php
+++ b/tests/ClientTest.php
@@ -15,6 +15,9 @@ public function setUp()
         $this->client = new Client($this->stream, $this->protocol, $this->splitter);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCtorOptionalArgs()
     {
         $this->stream = $this->getMockBuilder('React\Stream\DuplexStreamInterface')->getMock();
diff --git a/tests/FactoryTest.php b/tests/FactoryTest.php
index ce3dcaf..f011d72 100644
--- a/tests/FactoryTest.php
+++ b/tests/FactoryTest.php
@@ -16,6 +16,9 @@ public function setUp()
         $this->factory = new Factory($this->loop, $this->connector, $this->prober);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCtorOptionalArgs()
     {
         new Factory($this->loop);
diff --git a/tests/FunctionalTest.php b/tests/FunctionalTest.php
index 78b8fb5..4ba0bd0 100644
--- a/tests/FunctionalTest.php
+++ b/tests/FunctionalTest.php
@@ -43,6 +43,9 @@ public function setUp()
         }
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testCreateClient()
     {
         $factory = new Factory(self::$loop);
@@ -164,6 +167,7 @@ public function testWriteHeartBeatDefaultsToCurrentTime(Client $client)
 
     /**
      * @depends testCreateClient
+     * @doesNotPerformAssertions
      */
     public function testClose(Client $client)
     {