Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gzip content encoding #49

Closed
clue opened this issue Mar 7, 2016 · 5 comments
Closed

Implement gzip content encoding #49

clue opened this issue Mar 7, 2016 · 5 comments

Comments

@clue
Copy link
Owner

clue commented Mar 7, 2016

Also refs reactphp/http-client#37

@clue
Copy link
Owner Author

clue commented Mar 7, 2016

This should be fairly easy to implement for the Promise-based API alone, but the streaming API would need a streaming zlib decoder, see also clue/reactphp-zlib#9.

@clue
Copy link
Owner Author

clue commented Feb 14, 2018

Note that this affected both Transfer-Encoding: gzip and Content-Encoding: gzip. The former can be used for transparent on-the-fly compression, while the latter is the one that is actually in use for most HTTP servers, see also https://stackoverflow.com/questions/11641923/transfer-encoding-gzip-vs-content-encoding-gzip and https://stackapps.com/questions/916/why-content-encoding-gzip-rather-than-transfer-encoding-gzip.

@clue clue added this to the v2.6.0 milestone Nov 5, 2018
@clue clue modified the milestones: v2.6.0, v2.7.0 Apr 3, 2019
@irazasyed
Copy link

Any progress with this? Just hit a roadblock while working on a project.

@clue
Copy link
Owner Author

clue commented Jul 31, 2019

You can manually specify the required HTTP request headers and decompress the response body if the HTTP response indicates compression.

In the future, this should (will) be done automatically. As much as I'd like to commit to specific date, I can only say that we will get to this feature as soon as time permits.

(If you need this for a commercial project and/or you want to sponsor this feature, feel free to reach out and send me an email)

@clue clue modified the milestones: v2.7.0, v2.8.0 Feb 24, 2020
@clue clue modified the milestones: v2.8.0, v2.9.0 May 8, 2020
@clue clue mentioned this issue Jun 20, 2020
@clue clue removed this from the v2.9.0 milestone Jul 1, 2020
@clue
Copy link
Owner Author

clue commented Jul 12, 2020

I have to close this one as per #177 now that future development will focus on https://github.com/reactphp/http instead.

I've migrated this ticket to reactphp/http#377.

@clue clue closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants