1187 migrate collections and spaces as v2 metadata. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will be easier to build a collection hierarchy from this
tcnichol
changed the title
longshuicy
reviewed
Aug 30, 2024
|
I think I've addressed all comments and everything is working. Got rid of all the print statements I had accidentally checked in for debugging and did some better logging for space and collection. For posting the space metadata for a dataset, I added a try/except so if we're using v1 without my fix to return the space author, we will post space metadata based on the fields that we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress for now.
To test this, you will first need to have an admin user in v2, and you will have to add the metadata definitions. I have added a new 'Collection' metadata definition. Right now this just has a field for the collection_name and collection_id, along with fields for parents. To handle nested collections beyond 1 level, or to handle datasets that are in more than one collection, the definition will need to change.