-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS/keepOn did not finish the future #15
base: master
Are you sure you want to change the base?
Conversation
@@ -25,6 +25,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result { | |||
else if ([@"keepOn" isEqualToString:call.method]) { | |||
NSNumber *b = call.arguments[@"on"]; | |||
[[UIApplication sharedApplication] setIdleTimerDisabled:b.boolValue]; | |||
result(nil); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major change of this PR. @clovisnicolas could you merge & release a update on pub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clovisnicolas any chance you could review/merge this fix?
@ened If you only want to use the wakelock functionality, you could use wakelock, which I created due to lacking support from @clovisnicolas. In wakelock, this problem is fixed. |
@clovisnicolas Hi Clovis, I'm having this bug too on iOS, can you please merge this? |
@kevinrodriguez-io Is there something about |
@creativecreatorormaybenot the main reason I'd like this fixed is that Chewie's video player uses flutter_screen under the hood: https://github.com/brianegan/chewie/blob/master/pubspec.yaml#L16 Otherwise your |
@recastrodiaz Thanks for the information. I will propose a PR to the video player that switches to
I will post it here when done. |
The iOS side of the plugin was missing a result(nil) call for the keepOn function, which has been fixed.
Also included: