Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS/keepOn did not finish the future #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ened
Copy link
Contributor

@ened ened commented May 23, 2019

The iOS side of the plugin was missing a result(nil) call for the keepOn function, which has been fixed.
Also included:

  • Update iOS project files to latest versions
  • Include 1024x1024 icon for example

@@ -25,6 +25,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
else if ([@"keepOn" isEqualToString:call.method]) {
NSNumber *b = call.arguments[@"on"];
[[UIApplication sharedApplication] setIdleTimerDisabled:b.boolValue];
result(nil);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major change of this PR. @clovisnicolas could you merge & release a update on pub?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clovisnicolas any chance you could review/merge this fix?

@ened ened force-pushed the ios/keep-on-future branch from 4f2f6d5 to 085b2bc Compare June 6, 2019 01:33
@creativecreatorormaybenot

@ened If you only want to use the wakelock functionality, you could use wakelock, which I created due to lacking support from @clovisnicolas. In wakelock, this problem is fixed.

@kevinrodriguez-io
Copy link

@clovisnicolas Hi Clovis, I'm having this bug too on iOS, can you please merge this?

@creativecreatorormaybenot

@kevinrodriguez-io Is there something about wakelock missing for you?

@recastrodiaz
Copy link

recastrodiaz commented Oct 4, 2019

@creativecreatorormaybenot the main reason I'd like this fixed is that Chewie's video player uses flutter_screen under the hood: https://github.com/brianegan/chewie/blob/master/pubspec.yaml#L16

Otherwise your wakelock library works really well!

@creativecreatorormaybenot
Copy link

creativecreatorormaybenot commented Oct 4, 2019

@recastrodiaz Thanks for the information. I will propose a PR to the video player that switches to wakelock because of two reasons:

  • It does not use the brightness control in flutter_screen.

  • flutter_screen is not being maintained.

I will post it here when done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants