Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up ariakit/combobox and InlineCombobox #238

Open
cloverich opened this issue Sep 13, 2024 · 0 comments
Open

Clean-up ariakit/combobox and InlineCombobox #238

cloverich opened this issue Sep 13, 2024 · 0 comments

Comments

@cloverich
Copy link
Owner

Added this to support #223 but when I cleaned up drop downs (#237 ) I didn't have enough time to do this work. I think rather than having an additional library, better to go all in on radix and build this internally, especially since #234 implements a similar pattern. Most important is to use the same styling tailwind classes as the other menu's, so theming / style changes are easy.

Choices here are probably:

  • Keep ariakit if it seems stable long-term
  • Move to a more established library like cmdk
  • In-house it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant