Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking links in Editor opens external links in Electron window #144

Closed
Tracked by #116
cloverich opened this issue Jan 27, 2024 · 1 comment · Fixed by #153
Closed
Tracked by #116

Clicking links in Editor opens external links in Electron window #144

cloverich opened this issue Jan 27, 2024 · 1 comment · Fixed by #153
Labels
bug Something isn't working

Comments

@cloverich
Copy link
Owner

Screenshot 2024-01-27 at 8 21 37 AM

If you click the external link in the new edit menu, it opens an electron window to the site; this is a potential security risk. Instead, it should be opening in the users system browser.

Related:

@cloverich cloverich added the bug Something isn't working label Jan 27, 2024
This was referenced Jan 27, 2024
@cloverich
Copy link
Owner Author

Should tackle this as part of #53 -- handling this is well covered in https://www.electronjs.org/docs/latest/tutorial/security#13-disable-or-limit-navigation

I implemented this in a prior Chronicles version; I'm not sure this was ever setup in this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant