Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop file + link to it #121

Closed
Tracked by #116
cloverich opened this issue Jan 18, 2024 · 0 comments · Fixed by #153
Closed
Tracked by #116

Drag and drop file + link to it #121

cloverich opened this issue Jan 18, 2024 · 0 comments · Fixed by #153

Comments

@cloverich
Copy link
Owner

cloverich commented Jan 18, 2024

This is one of several features required before I can import my Notion documents. I have documents that reference PDFs and perhaps other files, that I don't intend to render inline (i.e. no image or video preview). Instead, probably:

  • Copy the file to files location
  • Render a link to it

What does the link do? Doesn't render in app. Downloading doesn't make sense. Open finder to it could be nice; but then #62 gets more complicated.

UPDATE: Based on my work implementing video (#54 ) I learned a few things that will be relevant; don't want to forget.

  • Generic drag and drop file handler: Both image and video plugins manage "uploading" files; the (plate) image plugin actually eats the event if its not video, so the video plugin must come after it. It may make sense to consolidate all file handling into a single plugin, that can manage implementing or delegating for images, videos, and other elements
  • Need to determine how file links will be represented in markdown: As links, as image tags, or both. Then need to update the handlers (for those) in the internal remark-slate-transformer code to handle files as well.
@cloverich cloverich mentioned this issue Jan 18, 2024
18 tasks
@cloverich cloverich changed the title Other files support (preview links is fine). This is one of several features required before I can import my Notion documents Drag and drop file + link to it Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant