NameSpace Admin page locators actions and step definition addition #16
Conversation
| @FindBy(how = How.XPATH, using = "//a[contains(text(),\"Switch to\")]") | ||
| public static WebElement switchToNameSpaceButton; | ||
|
|
||
| @FindBy(how = How.XPATH, using = "//div[@class=\"namespace-and-caret\"]") |
There was a problem hiding this comment.
If we can find an Id for these locators we should use them. As class names can be changed in UI mostly.
There was a problem hiding this comment.
I tried to find ID but they are not available for these locators so going with the same only
| CdfNameSpaceAdminActions.switchToNewNameSpace(); | ||
| } | ||
|
|
||
| @Then("Verify if the switch is successful by checking the current {string} value") |
There was a problem hiding this comment.
It can be changed something like, 'Verify the namespace is switched to {string} successfully'
There was a problem hiding this comment.
yes changed it to the desired statement .
| CdfNameSpaceAdminLocators.nameSpaceModules(tabName, nameSpaceName)); | ||
| } | ||
|
|
||
| public static void clickOnNameSpaceAdminTab() { |
There was a problem hiding this comment.
Change the method as this and the above one has the same naming only having added s letter.
There was a problem hiding this comment.
yes changed the method name to openNamespaceAdminPage()
| ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.editPreferencesButton); | ||
| } | ||
|
|
||
| public static void switchOnNameSpace(String nameSpaceName) { |
There was a problem hiding this comment.
switchOnNameSpace to switchToNameSpace
There was a problem hiding this comment.
Done , changed
| ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.switchNameSpace(nameSpaceName)); | ||
| } | ||
|
|
||
| public static void createProfileforNameSpace(String nameSpaceName) { |
There was a problem hiding this comment.
Fix the came casing : createProfileforNameSpace
There was a problem hiding this comment.
changed to createProfileForNamespace()
| } | ||
|
|
||
| public static void addNameSpacefromHamnugerMenu() { | ||
| ElementHelper.clickOnElement(CdfNameSpaceAdminLocators.addNamespace); |
There was a problem hiding this comment.
Fix the camel casing in above 2 method names.
There was a problem hiding this comment.
Also fix the Hamburger spelling.
There was a problem hiding this comment.
fixed the spelling , changed the method name to addNamespaceFromHamburgerMenu()
| } | ||
|
|
||
| /** | ||
| * Verify if the added Preferences reset is validated successfully |
There was a problem hiding this comment.
Verify if the added Preferences reset is validated successfully to Verify if the added Preferences reset is successful
There was a problem hiding this comment.
Changed the comment to Verify if the added Preferences reset is successful
| CdfNameSpaceAdminActions.selectHamburgerMenuList(tabName); | ||
| } | ||
|
|
||
| @Then("Set nameSpace preferences with key: {string} and value: {string}") |
There was a problem hiding this comment.
I believe we should write the Step definitions normally and not in camel case, name space is fine.
There was a problem hiding this comment.
Thanks , changed it to namespace
| CdfPluginPropertiesActions.replaceValueInInputProperty("projectId", "projectId"); | ||
| } | ||
|
|
||
| @Then("Verify that the user is navigated to nameSpace admin page successfully") |
There was a problem hiding this comment.
Verify that the user is navigated to nameSpace admin page successfully
to
Verify if user sucessfully navigated to name space admin page
There was a problem hiding this comment.
Changed it to the desired statement .
| } | ||
|
|
||
| @Then("Verify that the user is navigated to nameSpace admin page successfully") | ||
| public void verifyThatHubPageIsSuccessfullyOpened() { |
There was a problem hiding this comment.
Also the method name should be relevant with the step here the method says verify if hub page is opened but in step we are saying verify is user is navigated to name space admin page
There was a problem hiding this comment.
Yes , changed it to verifyThatNamespacePageIsSuccessfullyOpened()
rahuldash171
force-pushed
the
cdap_e2e_NameSpaceAdmin_FW
branch
from
bc441b9 to
ca3dc6d
Compare
rahuldash171
force-pushed
the
cdap_e2e_NameSpaceAdmin_FW
branch
from
ca3dc6d to
86c646f
Compare
…ors were removed which were common in Sys admin and Namespace admin . Sys admin FW PR is merged
Page object model setup for New module Namespace admin .
New locators , actions and step def added .