Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

feat(resolvers): Consider changing IPNetResolver to not return an error for empty strings #327

Open
erezrokah opened this issue Jun 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@erezrokah
Copy link
Member

Currently the IPNetResolver returns an error for empty strings. The GCP providers ignore those in specific cases, see https://github.com/cloudquery/cq-provider-gcp/blob/49238085984bc25468ced7484761a3ceb1b7a99e/client/error.go#L59
and https://github.com/cloudquery/cq-provider-gcp/blob/8db6d1e043aec6b17f1f30afc3a0cb551595e34e/resources/services/kubernetes/clusters.go#L145

Ignoring empty strings could be a good default for other providers too, so we should consider it.

The relevant code to update is here

func IPNetResolver(path string) ColumnResolver {

We should first see if other providers experience the same issue as the GCP one

@bbernays
Copy link
Contributor

In Azure, some resources are able to return an empty string as a valid response:
cloudquery/cq-provider-azure@3604559

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants