Feat: Add Support for DB Instance Role Associations #132
Conversation
korenyoni
force-pushed
the
feat/role-associations
branch
from
bc90aba to
1babcf5
Compare
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_IAM_60 Added /main.tf aws_db_instance.default BC_AWS_GENERAL_46 Added /main.tf aws_db_instance.default
There was a problem hiding this comment.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_46 Added /main.tf aws_db_instance.default BC_AWS_IAM_60 Added /main.tf aws_db_instance.default
korenyoni
force-pushed
the
feat/role-associations
branch
2 times, most recently
from
7f26613 to
e64bb5f
Compare
korenyoni
force-pushed
the
feat/role-associations
branch
from
3160966 to
f2bf4c1
Compare
|
/test all |
…ing known before apply).
|
/test all |
…s not being known before apply)." This reverts commit fe2d3ad.
|
/test all |
|
/test all |
…orm-aws-rds into feat/role-associations
|
/test all |
|
/test all |
1 similar comment
|
/test all |
… terraform_docs).
…orm-aws-rds into feat/role-associations
|
/test all |
versions.tf
Outdated
| @@ -1,14 +1,10 @@ | |||
| terraform { | |||
| required_version = ">= 0.13.0" | |||
| required_version = ">= 1.0.0" | |||
There was a problem hiding this comment.
Woah. This is the first time we're doing this I believe.
There was a problem hiding this comment.
We still have engagements using older versions. I think we'll need another approval on this if this is needed. Could you explain why this is being bumped to 1.0 ?
There was a problem hiding this comment.
There's an issue with https://github.com/cloudposse/terraform-aws-s3-bucket/blob/6947cac37cdf809192f803d02cb87bce87dee35d/main.tf#L376 not being able to be determined when the module enabled=false
But yes, this is not ideal
There was a problem hiding this comment.
I did explain it briefly in the why section of my PR description
The comprehensive Terratest suite in examples/complete and test/src will only work with Terraform 1.0.0 and above, and otherwise will result in "count cannot be determined before apply" errors.
…orm-aws-rds into feat/role-associations
|
/test all |
…orm-aws-rds into feat/role-associations
|
/test all |
|
Bump! Is there anything blocking this PR from being merged, that we can help with? |
|
/test terratest |
|
/test test/terratest |
|
This pull request is now in conflict. Could you fix it @korenyoni? 🙏 |
|
|
||
| module "role" { | ||
| source = "cloudposse/iam-role/aws" | ||
| version = "0.14.0" |
There was a problem hiding this comment.
| version = "0.14.0" | |
| version = "0.16.2" |
| #source = "cloudposse/s3-bucket/aws" | ||
| #version = "0.44.1" | ||
| # TODO: remove |
|
/test test/terratest |
| enabled = local.s3_integration_enabled | ||
|
|
||
| acl = "private" | ||
| policy = join("", data.aws_iam_policy_document.bucket_policy.*.json) |
There was a problem hiding this comment.
I think this may be causing the failure
what
1.0.0(see below).why
examples/completeandtest/srcwill only work with Terraform1.0.0and above, and otherwise will result in "count cannot be determined before apply" errors.references