Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS Provider V5 #167

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Support AWS Provider V5 #167

merged 3 commits into from
Oct 16, 2023

Conversation

max-lobur
Copy link
Contributor

what

Support AWS Provider V5
Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 7, 2023
@max-lobur max-lobur requested review from a team as code owners June 7, 2023 16:43
bridgecrew[bot]
bridgecrew bot reviewed Jun 7, 2023
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@max-lobur
Copy link
Contributor Author

/terratest

@milldr milldr mentioned this pull request Oct 16, 2023
Merged
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur removed the no-release Do not create a new release (wait for additional code changes) label Oct 16, 2023
@max-lobur
Copy link
Contributor Author

/terratest

@max-lobur max-lobur enabled auto-merge (squash) October 16, 2023 17:45
Nuru
Nuru approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to leave the join() in for now, but in the future, use one()

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
@max-lobur max-lobur merged commit 102fe02 into main Oct 16, 2023
@max-lobur max-lobur deleted the aws_v5 branch October 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@Nuru Nuru Nuru approved these changes

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-lobur @Nuru