Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression for NLB container name #291

Merged

Conversation

adamantike
Copy link
Contributor

what

A regression was introduced in a previous commit, where the NLB container name is being set to the value of the alb_container_name variable, instead of using nlb_container_name.

A regression was introduced in a previous commit, where the NLB
container name is being set to the value of the `alb_container_name`
variable, instead of using `nlb_container_name`.
@adamantike adamantike requested review from a team as code owners October 14, 2024 15:23
@mergify mergify bot added the triage Needs triage label Oct 14, 2024
@gberenice
Copy link
Contributor

/terratest

Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gberenice gberenice merged commit ca3040f into cloudposse:main Oct 15, 2024
19 checks passed
@mergify mergify bot removed the triage Needs triage label Oct 15, 2024
Copy link
Contributor

These changes were released in v2.2.0.

@adamantike adamantike deleted the fix/regression-for-nlb-container-name branch October 15, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants