Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFS Volume configuration does not get passed on #220

Open
xmj opened this issue Mar 2, 2023 · 0 comments
Open

EFS Volume configuration does not get passed on #220

xmj opened this issue Mar 2, 2023 · 0 comments
Labels
bug 🐛 An issue with the system

Comments

@xmj
Copy link

xmj commented Mar 2, 2023

Describe the Bug

When specifying an EFS Volume configuration in var.volumes, this gets handed to the cloudposse/ecs-alb-service-task/aws module via its variable var.docker_volumes, in which the EFS part will be dropped.

If my reading of this repo is correct the bug was caused in

23c9105

through an automated update caused by a variable refactoring in the ecs-alb-service-task module.
cloudposse/terraform-aws-ecs-alb-service-task@4294ee2

Expected Behavior

Passing the efs_volume_configuration list of maps will create an EFS Volume Configuration in the Task Definition

Steps to Reproduce

Create a VPC, Subnet, ALB, EFS volume, then try to pass the latter into a container.

A module call like this should create an EFS Volume configuration

module "web_app" {
  source = "cloudposse/ecs-web-app/aws"

  volumes = [{
    name = "service-storage"
    host_path = ""
    docker_volume_configuration = []

    efs_volume_configuration  = [
    {
      file_system_id     = aws_efs_file_system.foo.id
      root_directory     = "/"
      transit_encryption = "ENABLED"
      transit_encryption_port = null
      authorization_config = [
      {
        access_point_id = aws_efs_access_point.foo.id
        iam             = "ENABLED"
      }
      ]
    }
    ]
  }]
}

Screenshots

No response

Environment

  • OS: Fedora 37
  • Module: latest (1.7.0)

Additional Context

No response

@xmj xmj added the bug 🐛 An issue with the system label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant