[aws api] Ordering of env vars does not work

[bendavies]

Hi there,

This is just for visibility here rather than anything.
There is some effort here to ensure environment vars are sorted as to not produce unnecessary diffs when any changes are made.

Unfortunately, it doesn't work too well because of a bug in the aws provider:
hashicorp/terraform-provider-aws#3035

cheers!

[aknysh]

@bendavies thanks for reporting

[rafilkmp3]

this force replace all time module.td.aws_ecs_task_definition.td must be replaced

[nitrocode]

This has been bugging me too. There is currently sorting logic in this module.

terraform-aws-ecs-container-definition/main.tf

Lines 2 to 7 in d2e23fd

	# Sort environment variables so terraform will not try to recreate on each plan/apply
	env_vars = var.environment != null ? var.environment : []
	env_vars_keys = [for m in local.env_vars : lookup(m, "name")]
	env_vars_values = [for m in local.env_vars : lookup(m, "value")]
	env_vars_as_map = zipmap(local.env_vars_keys, local.env_vars_values)
	sorted_env_vars_keys = sort(local.env_vars_keys)

If there is an improvement to make this module's environment equivalent to the aws api, we'd love to know and pull requests are always welcome.

[bendavies]

fixed via hashicorp/terraform-provider-aws#11463