Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add External Link Icon #320

Open
osterman opened this issue Dec 13, 2018 · 3 comments
Open

Add External Link Icon #320

osterman opened this issue Dec 13, 2018 · 3 comments
Assignees
@osterman @finnsky
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@osterman
Copy link
Member

what

image

  • I'm not crazy about my design in this mock up. It's just trying to convey what I want.

why

  • It's annoying when clicking on header links and getting taken to a new site by surprise
  • It's common practice to indicate when links to to an external site
@osterman osterman added the enhancement New feature or request label Dec 14, 2018
@osterman
Copy link
Member Author

Colors should probably be different and size too.

@finnsky
Copy link
Contributor

finnsky commented Jan 26, 2019

@osterman i think most obvious will be icon after link name
https://fontawesome.com/icons/external-link?style=solid

@osterman
Copy link
Member Author

Let's hold off on this one. I think it will look too ugly. Haha.

@osterman osterman added the wontfix This will not be worked on label Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osterman osterman

@finnsky finnsky

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osterman @finnsky