Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Add detection of submodule changes (for autoplan) #19

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Add detection of submodule changes (for autoplan) #19

merged 1 commit into from
Oct 25, 2018

Conversation

aknysh
Copy link

@aknysh aknysh commented Oct 25, 2018

what

  • Add detection of submodule changes (for autoplan)

why

  • If a submodule gets modified, GitHub API returns it as a directory
  • File matching pattern won't match it, so we need to check if it's a dir
  • Only submodules will be directories, not regular files from the main repo

@aknysh aknysh self-assigned this Oct 25, 2018
@aknysh aknysh requested a review from osterman October 25, 2018 03:51
@osterman osterman mentioned this pull request Oct 25, 2018
Closed
@osterman
Copy link

Also related to runatlantis#311

@aknysh aknysh merged commit e239218 into master Oct 25, 2018
@aknysh aknysh deleted the add-submodule-changes-detection branch October 25, 2018 04:25
@osterman osterman mentioned this pull request Dec 26, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osterman osterman osterman approved these changes

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @osterman