Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme updated, BC compliance check fixed #26

Merged
merged 6 commits into from
Jan 30, 2021
Merged

readme updated, BC compliance check fixed #26

merged 6 commits into from
Jan 30, 2021

Conversation

maximmi
Copy link
Contributor

@maximmi maximmi commented Jan 26, 2021 •
edited
Loading

what

  • BridgeCrew compliance checks fix
  • readme updated
  • code clean up
  • Skipping Encrypt SNS Topic Data in example/test modules
  • Container Insights Enabled in example/test modules

why

  • To be able to position our modules as standards compliant
  • Providing explicit note about policy attached directly to user
  • removed unnecessary providers dependencies
  • To comply BridgeCrew check

references

@maximmi maximmi requested a review from osterman January 26, 2021 15:57
@maximmi maximmi requested review from a team as code owners January 26, 2021 15:57
@maximmi maximmi requested review from dotCipher and removed request for a team January 26, 2021 15:57
@maximmi
Copy link
Contributor Author

maximmi commented Jan 26, 2021

/test all

@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

1 similar comment
@maximmi
Copy link
Contributor Author

maximmi commented Jan 28, 2021

/test all

@maximmi maximmi merged commit 6b1161a into master Jan 30, 2021
@maximmi maximmi deleted the bc-compliance branch January 30, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maximmi @osterman @cloudpossebot