Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing issues not being closed after instance roll #86

Open
mwarkentin opened this issue Jun 21, 2019 · 8 comments
Open

Existing issues not being closed after instance roll #86

mwarkentin opened this issue Jun 21, 2019 · 8 comments

Comments

@mwarkentin
Copy link

mwarkentin commented Jun 21, 2019

👋 again

After resolving the previous issue which was blocking our sync w/ jira, we are noticing that we have old jira tickets which aren't being resolved. When we run a deploy, we push a new set of instances using a whole new AMI, rather than updating the OS in place. I'm not sure if this is contributing.

Here's an example jira which was created on april 16:

Halo detected sva issue in server prod-integproxy-app--i-0a23729ade516f185

Vulnerable package: accountsservice version 0.6.40-2ubuntu11.3

Critical: False
CVE-2018-14036 Score: 4.0 Supressed: False
Server prod-integproxy-app--i-0a23729ade516f185 at -unknown-

Here's a list of our currently active servers, you can see that there aren't any with a matching server id:

Any thoughts on how to handle this? I did retire the previous set of instances shortly after the deploy - is it possible this would've been picked up and resolved if the instances were just deactivated instead of retired?

Ideally, all issues related to instances which are no longer active should be resolved as part of the sync (I think).

@ashmastaflash
Copy link
Contributor

@mwarkentin sorry to keep you waiting on a response.

Yes, all issues that are closed in Halo should be resolved on the Jira side with the next sync. Can you search in the logs from the integration for references to the IDs of the issues that aren't being closed? Are you seeing an attempted, but failing close? Or are they not coming up at all in the logs as subject to closure?

@mwarkentin
Copy link
Author

I'll check into the logs tomorrow. :)

@mwarkentin
Copy link
Author

Hi @ashmastaflash , I don't see any indication that it's trying to do anything with those IDs. Here's an example:

I'm wondering if it's skipping them due to the timestamp?

@mwarkentin
Copy link
Author

I'm going to try setting the timestamp back before that issue was created and see if it syncs up.

@mwarkentin
Copy link
Author

Didn't seem to pull in any more issues:

@mwarkentin
Copy link
Author

Happy to hop on a call sometime today if you'd like to debug directly.

@ashmastaflash
Copy link
Contributor

If the timestamp was moved forward to a point after when the issue was closed, then the integration would not have closed it. You could try setting the SSM timestamp back to just before the timestamp for issue closure and running the integration again, and see if it closes.

Are you seeing a common thread between all issues that haven't closed, like a window of time, or a specific type of issue?

@mwarkentin
Copy link
Author

Resetting the SSM timestamp back to before the issue was created was what I attempted to do, but it didn't seem to pick up the issue even then, and then it "reset" the timestamp back to the current time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants