Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Annotations and Command-Line Flags Should Work Cohesively #1403

Open
aauren opened this issue Nov 29, 2022 · 1 comment
Open

Node Annotations and Command-Line Flags Should Work Cohesively #1403

aauren opened this issue Nov 29, 2022 · 1 comment
Labels
feature override-stale Don't allow automatic management of stale issues / PRs

Comments

@aauren
Copy link
Collaborator

aauren commented Nov 29, 2022

Is your feature request related to a problem? Please describe.
Node annotations and command-line flags for BGP peers do not currently work together. Instead they end up being mutually exclusive. If kube-router detects that you have configured peers via command-line flags, it doesn't even attempt to read information from node annotations. This can be confusing for users that may want leverage both methods of configuration for different purposes.

Describe the solution you'd like
Where possible, node annotations and command-line parameters should work together cohesively

@aauren aauren added the feature label Nov 29, 2022
@aauren
Copy link
Collaborator Author

aauren commented Nov 29, 2022

Relates to #1371

@aauren aauren added the override-stale Don't allow automatic management of stale issues / PRs label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature override-stale Don't allow automatic management of stale issues / PRs
Projects
None yet
Development

No branches or pull requests

1 participant