Skip to content

Commit

Permalink
scripts/build: gracefully handle spaces in image= parameter
Browse files Browse the repository at this point in the history
A space in the image= or modules= parameter, while not really useful,
should not cause strange errors messages about bad parameters to module.py.
Quoting was missing.

Signed-off-by: Nadav Har'El <[email protected]>
  • Loading branch information
nyh committed Mar 14, 2019
1 parent 12b39c6 commit 3f7ce19
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/build
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ if [ "$export" == "selected" ]
then
no_required_arg="--no-required"
fi
fs_type=$fs_type jdkbase=$jdkbase ARCH=$arch mode=$mode OSV_BASE=$SRC OSV_BUILD_PATH=$OSV_BUILD_PATH scripts/module.py $j_arg build -c $modules $usrskel_arg $no_required_arg
fs_type=$fs_type jdkbase=$jdkbase ARCH=$arch mode=$mode OSV_BASE=$SRC OSV_BUILD_PATH=$OSV_BUILD_PATH scripts/module.py $j_arg build -c "$modules" $usrskel_arg $no_required_arg

bootfs_manifest=$manifest make "${args[@]}" | tee -a build.out
# check exit status of make
Expand Down

0 comments on commit 3f7ce19

Please sign in to comment.