-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment form reply behavior #1389
Comments
@tylersticka I started working on adding in the reply form. It's feeling a little bulky to my eye. I wonder if it would be helpful to give this a design pass focusing on:
What do you think? Would it be helpful for me to do some explorations before I get too far on this? |
This feels a little exaggerated to me in your screenshot since the component isn't constrained width-wise. In practice, we'll be displaying the comment thread inside of a prose-width container object.
I'm open to ideas. I think it will simplify things technically if the form is consistent between replies and new comments, so any ideas would ideally translate well between both.
Very open to this! At the very least we should probably transform the containing comment into the |
That makes sense. I'll try using the |
And if |
That makes sense 👍 |
Our Comment component contains a placeholder for replies, but it does not yet integrate our Comment Form.
The experience should behave similarly to how it does on the live site:
Note the focus of the first field and the reply form popping up at the top rather than scrolling below the other replies.
The text was updated successfully, but these errors were encountered: