Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment form reply behavior #1389

Closed
tylersticka opened this issue Jul 12, 2021 · 5 comments · Fixed by #1423
Closed

Comment form reply behavior #1389

tylersticka opened this issue Jul 12, 2021 · 5 comments · Fixed by #1423
Assignees
Labels

Comments

@tylersticka
Copy link
Member

Our Comment component contains a placeholder for replies, but it does not yet integrate our Comment Form.

The experience should behave similarly to how it does on the live site:

reply-behavior

Note the focus of the first field and the reply form popping up at the top rather than scrolling below the other replies.

@Paul-Hebert
Copy link
Member

@tylersticka I started working on adding in the reply form. It's feeling a little bulky to my eye. I wonder if it would be helpful to give this a design pass focusing on:

  1. Making the form more compact when displayed inline after a comment
  2. Differentiating the reply form from the comment you're replying to

What do you think? Would it be helpful for me to do some explorations before I get too far on this?

Screen Shot 2021-07-16 at 4 31 57 PM

@tylersticka
Copy link
Member Author

It's feeling a little bulky to my eye.

This feels a little exaggerated to me in your screenshot since the component isn't constrained width-wise. In practice, we'll be displaying the comment thread inside of a prose-width container object.

Making the form more compact when displayed inline after a comment

I'm open to ideas. I think it will simplify things technically if the form is consistent between replies and new comments, so any ideas would ideally translate well between both.

Differentiating the reply form from the comment you're replying to

Very open to this! At the very least we should probably transform the containing comment into the --thread variety.

@Paul-Hebert
Copy link
Member

That makes sense. I'll try using the --thread modifier and sticking the whole thing in a Prose container. I'll see how that looks and whether it still feels bulky or not 👍

@tylersticka
Copy link
Member Author

That makes sense. I'll try using the --thread modifier and sticking the whole thing in a Prose container. I'll see how that looks and whether it still feels bulky or not 👍

And if --thread is something we end up needing to toggle on and off with JavaScript, it might actually be better suited for an is-threaded state class rather than a modifier! That may have been short-sighted of me

@Paul-Hebert
Copy link
Member

That makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants